Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2613723004: Rename HTMLEntityNames.in to HTMLEntityNames.csv (Closed)

Created:
3 years, 11 months ago by ktyliu
Modified:
3 years, 11 months ago
Reviewers:
sashab, bugsnash
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch, loading-reviews+parser_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename HTMLEntityNames.in to HTMLEntityNames.csv BUG=677884 Review-Url: https://codereview.chromium.org/2613723004 Cr-Commit-Position: refs/heads/master@{#441841} Committed: https://chromium.googlesource.com/chromium/src/+/53d00d666c1fbd943a11b9b12a0e0817be654cfb

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2231 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/html/parser/HTMLEntityNames.csv View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/Source/core/html/parser/HTMLEntityNames.in View 1 chunk +0 lines, -2231 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
ktyliu
Good morning Bugs, Sasha wanted to convert .in files to .yml, but I noticed that ...
3 years, 11 months ago (2017-01-05 23:14:25 UTC) #4
sashab
Sorry to hijack review -- don't want to leave this one too long in case ...
3 years, 11 months ago (2017-01-05 23:54:37 UTC) #6
ktyliu
On 2017/01/05 23:54:37, sashab wrote: > Sorry to hijack review -- don't want to leave ...
3 years, 11 months ago (2017-01-06 00:07:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613723004/20001
3 years, 11 months ago (2017-01-06 01:11:38 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 02:40:36 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/53d00d666c1fbd943a11b9b12a0e...

Powered by Google App Engine
This is Rietveld 408576698