Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 2613703003: Add base::PostDelayedTask(WithTraits). (Closed)

Created:
3 years, 11 months ago by fdoray
Modified:
3 years, 11 months ago
Reviewers:
robliao, gab
CC:
chromium-reviews, gab+watch_chromium.org, robliao+watch_chromium.org, fdoray+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add base::PostDelayedTask(WithTraits). base::PostDelayedTask(...) is less verbose than base::CreateTaskRunnerWithTraits(TaskTraits())->PostDelayedTask(...). The first usage of base::PostDelayedTaskWithTraits will be in https://codereview.chromium.org/2598483004/. BUG=553459 Review-Url: https://codereview.chromium.org/2613703003 Cr-Commit-Position: refs/heads/master@{#441723} Committed: https://chromium.googlesource.com/chromium/src/+/45cc9079ce70043ea3c2a051ba24b69e0ebd2b3a

Patch Set 1 #

Patch Set 2 : Add comment about BACKGROUND priority. #

Patch Set 3 : self-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -36 lines) Patch
M base/task_scheduler/post_task.h View 1 2 4 chunks +25 lines, -4 lines 0 comments Download
M base/task_scheduler/post_task.cc View 2 chunks +16 lines, -2 lines 0 comments Download
M base/task_scheduler/task_scheduler.h View 2 chunks +7 lines, -4 lines 0 comments Download
M base/task_scheduler/task_scheduler_impl.h View 1 chunk +4 lines, -3 lines 0 comments Download
M base/task_scheduler/task_scheduler_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M base/task_scheduler/task_scheduler_impl_unittest.cc View 6 chunks +40 lines, -13 lines 0 comments Download
M base/test/scoped_task_scheduler.cc View 2 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
fdoray
PTAL
3 years, 11 months ago (2017-01-04 20:41:58 UTC) #2
gab
lgtm
3 years, 11 months ago (2017-01-05 16:43:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613703003/40001
3 years, 11 months ago (2017-01-05 17:05:26 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 19:25:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/45cc9079ce70043ea3c2a051ba24...

Powered by Google App Engine
This is Rietveld 408576698