Issue 28149. Don't include non-Dart file into FileState.

Issue 28149. Don't include non-Dart file into FileState.

So, these non-Dart files are not include into 'knownFiles', and we
don't attempt to request CompilationUnitElement(s) for them in search.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/28149

Committed: https://github.com/dart-lang/sdk/commit/e6634d67f407e453f3b3944973de05f2d8718802

[Brian Wilkerson, 2017-01-05 14:52:01]

What is the effect (if any) of this change on the future of the Angular plugin?
Would it be better to place this restriction in the driver so that we can re-use
FileState for other kinds of drivers?

The spec doesn't restrict Dart code to only appearing in ".dart" files, and
there is a shared test that ensures we can import a library from a file that
does not end in ".dart". Does this break that?

[scheglov, 2017-01-05 17:14:48]

On 2017/01/05 14:52:01, Brian Wilkerson wrote:
> What is the effect (if any) of this change on the future of the Angular
plugin?
> Would it be better to place this restriction in the driver so that we can
re-use
> FileState for other kinds of drivers?

  FileState is Dart specific by design - imported / exported files, unlinked
units, api signatures, etc.

  The Angular plugin is not affected.
  HTML files are not imported.
  The plugin can use Dart infrastructure to perform Dart analysis.
  FileState stuff is not necessary for Angular HTML analysis.
  HTML files in Angular are just separate files, not graphs.


> The spec doesn't restrict Dart code to only appearing in ".dart" files, and
> there is a shared test that ensures we can import a library from a file that
> does not end in ".dart". Does this break that?

  For any practical purpose we limit Dart analysis to *.dart files anyway.
  See AnalysisContextImpl.getResolvedCompilationUnit2(),
AnalysisContextImpl.parseCompilationUnit(), etc.

[Brian Wilkerson, 2017-01-05 17:54:05]

Ok, then lgtm.

[scheglov, 2017-01-05 18:55:41]

Description was changed from

==========
Issue 28149. Don't include non-Dart file into FileState.

So, these non-Dart files are not include into 'knownFiles', and we
don't attempt to request CompilationUnitElement(s) for them in search.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/28149
==========

to

==========
Issue 28149. Don't include non-Dart file into FileState.

So, these non-Dart files are not include into 'knownFiles', and we
don't attempt to request CompilationUnitElement(s) for them in search.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/28149

Committed:
https://github.com/dart-lang/sdk/commit/e6634d67f407e453f3b3944973de05f2d8718802
==========

[scheglov, 2017-01-05 18:55:42]

Committed patchset #1 (id:1) manually as
e6634d67f407e453f3b3944973de05f2d8718802 (presubmit successful).