Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: pkg/analyzer/lib/src/dart/analysis/file_state.dart

Issue 2613683005: Issue 28149. Don't include non-Dart file into FileState. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/src/dart/analysis/driver_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/dart/analysis/file_state.dart
diff --git a/pkg/analyzer/lib/src/dart/analysis/file_state.dart b/pkg/analyzer/lib/src/dart/analysis/file_state.dart
index 70ba1ee4640368cd714a1382261f6e34ded1d91c..1608c33fe85796916ebbc7f44f55a77da3afcb5c 100644
--- a/pkg/analyzer/lib/src/dart/analysis/file_state.dart
+++ b/pkg/analyzer/lib/src/dart/analysis/file_state.dart
@@ -437,7 +437,7 @@ class FileState {
for (UnlinkedImport import in _unlinked.imports) {
if (!import.isImplicit) {
String uri = import.uri;
- if (!_isDartUri(uri)) {
+ if (_isDartFileUri(uri)) {
FileState file = _fileForRelativeUri(uri);
if (file != null) {
_importedFiles.add(file);
@@ -447,7 +447,7 @@ class FileState {
}
for (UnlinkedExportPublic export in _unlinked.publicNamespace.exports) {
String uri = export.uri;
- if (!_isDartUri(uri)) {
+ if (_isDartFileUri(uri)) {
FileState file = _fileForRelativeUri(uri);
if (file != null) {
_exportedFiles.add(file);
@@ -457,7 +457,7 @@ class FileState {
}
}
for (String uri in _unlinked.publicNamespace.parts) {
- if (!_isDartUri(uri)) {
+ if (_isDartFileUri(uri)) {
FileState file = _fileForRelativeUri(uri);
if (file != null) {
_partedFiles.add(file);
@@ -524,8 +524,8 @@ class FileState {
return true;
}
- static bool _isDartUri(String uri) {
- return uri.startsWith('dart:');
+ static bool _isDartFileUri(String uri) {
+ return !uri.startsWith('dart:') && AnalysisEngine.isDartFileName(uri);
}
}
« no previous file with comments | « no previous file | pkg/analyzer/test/src/dart/analysis/driver_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698