Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 2613663002: CSS Transitions: Fix flaky test extra-transition.html (Closed)

Created:
3 years, 11 months ago by Eric Willigers
Modified:
3 years, 11 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS Transitions: Fix flaky test extra-transition.html We reduce the duration of the test to avoid timeouts. The test has also been converted to use testharness. BUG=248938 Committed: https://crrev.com/9fd376e988691e1b08a9a0302237d22ef7098809 Cr-Commit-Position: refs/heads/master@{#441330}

Patch Set 1 #

Total comments: 6

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -95 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/transitions/extra-transition.html View 1 1 chunk +35 lines, -91 lines 0 comments Download
D third_party/WebKit/LayoutTests/transitions/extra-transition-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Eric Willigers
3 years, 11 months ago (2017-01-04 04:34:13 UTC) #4
alancutter (OOO until 2018)
lgtm with nits. https://codereview.chromium.org/2613663002/diff/1/third_party/WebKit/LayoutTests/transitions/extra-transition.html File third_party/WebKit/LayoutTests/transitions/extra-transition.html (right): https://codereview.chromium.org/2613663002/diff/1/third_party/WebKit/LayoutTests/transitions/extra-transition.html#newcode33 third_party/WebKit/LayoutTests/transitions/extra-transition.html:33: <ul id="features"> features element unnecessary. https://codereview.chromium.org/2613663002/diff/1/third_party/WebKit/LayoutTests/transitions/extra-transition.html#newcode34 ...
3 years, 11 months ago (2017-01-04 05:33:04 UTC) #7
Eric Willigers
https://codereview.chromium.org/2613663002/diff/1/third_party/WebKit/LayoutTests/transitions/extra-transition.html File third_party/WebKit/LayoutTests/transitions/extra-transition.html (right): https://codereview.chromium.org/2613663002/diff/1/third_party/WebKit/LayoutTests/transitions/extra-transition.html#newcode33 third_party/WebKit/LayoutTests/transitions/extra-transition.html:33: <ul id="features"> On 2017/01/04 05:33:04, alancutter wrote: > features ...
3 years, 11 months ago (2017-01-04 06:13:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613663002/20001
3 years, 11 months ago (2017-01-04 06:14:34 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-04 07:35:49 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 07:38:31 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9fd376e988691e1b08a9a0302237d22ef7098809
Cr-Commit-Position: refs/heads/master@{#441330}

Powered by Google App Engine
This is Rietveld 408576698