Remove the MockTransportChannel.

Remove the MockTransportChannel.

The channel_socket_adapter_unittests will depend on webrtc/p2p/mockicetransport.h instead of creating
its own MockTransportChannel which subclasses the TransportChannel. This CL make it easier to remove
the TransportChannel and TransportChannelImpl.

Relate CL: https://codereview.webrtc.org/2610663003

BUG=webrtc:6951
Review-Url: https://codereview.chromium.org/2613653002
Cr-Commit-Position: refs/heads/master@{#442301}
Committed: https://chromium.googlesource.com/chromium/src/+/a3751eadd3e72ad095f11aae3d91d7f32b2a99c0

[zhihuang1, 2017-01-04 00:36:59]

The CQ bit was checked by zhihuang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 00:37:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 00:44:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 00:44:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[zhihuang1, 2017-01-04 02:05:31]

zhihuang@chromium.org changed reviewers:
+ sergeyu@chromium.org

[zhihuang1, 2017-01-04 02:05:31]

Hi Sergey,

This CL is also a preparation of replacing the TransportChannl and
TransportChannelImpl with the IceTransportInternal. 

Please take a look.
Thanks!

[Sergey Ulanov, 2017-01-05 04:06:29]

lgtm after my comment is addressed

https://codereview.chromium.org/2613653002/diff/1/remoting/protocol/channel_s...
File remoting/protocol/channel_socket_adapter_unittest.cc (right):

https://codereview.chromium.org/2613653002/diff/1/remoting/protocol/channel_s...
remoting/protocol/channel_socket_adapter_unittest.cc:25: using
cricket::MockIceTransport;
Please don't use 'using' here. Instead use fully-qualified name below when
referencing this class.

[zhihuang1, 2017-01-09 18:26:56]

The CQ bit was checked by zhihuang@chromium.org

[zhihuang1, 2017-01-09 18:26:56]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/2613653002/#ps20001
(title: "Remove "using::"")

[commit-bot: I haz the power, 2017-01-09 18:27:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 19:05:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483986416534140,
"parent_rev": "f7d4caad1b47aa9b28713a164a1435feb31946c7", "commit_rev":
"a3751eadd3e72ad095f11aae3d91d7f32b2a99c0"}

[commit-bot: I haz the power, 2017-01-09 19:05:42]

Description was changed from

==========
Remove the MockTransportChannel.

The channel_socket_adapter_unittests will depend on
webrtc/p2p/mockicetransport.h instead of creating
its own MockTransportChannel which subclasses the TransportChannel. This CL make
it easier to remove
the TransportChannel and TransportChannelImpl.

Relate CL: https://codereview.webrtc.org/2610663003

BUG=webrtc:6951
==========

to

==========
Remove the MockTransportChannel.

The channel_socket_adapter_unittests will depend on
webrtc/p2p/mockicetransport.h instead of creating
its own MockTransportChannel which subclasses the TransportChannel. This CL make
it easier to remove
the TransportChannel and TransportChannelImpl.

Relate CL: https://codereview.webrtc.org/2610663003

BUG=webrtc:6951

Review-Url: https://codereview.chromium.org/2613653002
Cr-Commit-Position: refs/heads/master@{#442301}
Committed:
https://chromium.googlesource.com/chromium/src/+/a3751eadd3e72ad095f11aae3d91...
==========

[commit-bot: I haz the power, 2017-01-09 19:05:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a3751eadd3e72ad095f11aae3d91...