Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 261363002: Rename BrowserPluginGuestManagerDelegate to BrowserPluginGuestManager (Closed)

Created:
6 years, 7 months ago by Fady Samuel
Modified:
6 years, 7 months ago
Reviewers:
lazyboy, jam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, asanka, creis+watch_chromium.org, benjhayden+dwatch_chromium.org, tfarina, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, jochen+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@guestview_manager_cleanupguestmanager
Visibility:
Public.

Description

Rename BrowserPluginGuestManagerDelegate to BrowserPluginGuestManager BUG=364141, 330264 TBR=jamescook@chromium.org, michaelbai@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269705

Patch Set 1 #

Total comments: 8

Patch Set 2 : Addressed nits #

Total comments: 12

Patch Set 3 : Addressed nits #

Patch Set 4 : Removed unnecessary chagne #

Patch Set 5 : Fixed Android Build (Hopefully) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -441 lines) Patch
M android_webview/browser/aw_browser_context.h View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M android_webview/browser/aw_browser_context.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/guest_view/guest_view_manager.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/base/testing_profile.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_embedder.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_embedder.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_host_browsertest.cc View 1 2 4 chunks +7 lines, -8 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_message_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/browser/browser_plugin/test_guest_manager.h View 1 2 5 chunks +13 lines, -13 lines 0 comments Download
A + content/browser/browser_plugin/test_guest_manager.cc View 1 2 11 chunks +16 lines, -16 lines 0 comments Download
D content/browser/browser_plugin/test_guest_manager_delegate.h View 1 1 chunk +0 lines, -64 lines 0 comments Download
D content/browser/browser_plugin/test_guest_manager_delegate.cc View 1 2 1 chunk +0 lines, -172 lines 0 comments Download
M content/browser/download/download_manager_impl_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_browser.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/browser_context.h View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
A + content/public/browser/browser_plugin_guest_manager.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
A + content/public/browser/browser_plugin_guest_manager.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
D content/public/browser/browser_plugin_guest_manager_delegate.h View 1 1 chunk +0 lines, -65 lines 0 comments Download
D content/public/browser/browser_plugin_guest_manager_delegate.cc View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
M content/public/test/test_browser_context.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/public/test/test_browser_context.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/browser/shell_browser_context.h View 1 2 3 chunks +5 lines, -6 lines 0 comments Download
M content/shell/browser/shell_browser_context.cc View 1 2 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Fady Samuel
6 years, 7 months ago (2014-05-05 21:03:34 UTC) #1
lazyboy
lgtm https://codereview.chromium.org/261363002/diff/1/content/browser/browser_plugin/browser_plugin_embedder.h File content/browser/browser_plugin/browser_plugin_embedder.h (right): https://codereview.chromium.org/261363002/diff/1/content/browser/browser_plugin/browser_plugin_embedder.h#newcode35 content/browser/browser_plugin/browser_plugin_embedder.h:35: class BrowserPluginGuestManager; Dup https://codereview.chromium.org/261363002/diff/1/content/browser/browser_plugin/browser_plugin_guest.h File content/browser/browser_plugin/browser_plugin_guest.h (right): https://codereview.chromium.org/261363002/diff/1/content/browser/browser_plugin/browser_plugin_guest.h#newcode63 ...
6 years, 7 months ago (2014-05-05 21:47:45 UTC) #2
Fady Samuel
+jam@ for changes outside of browser_plugin Thanks! https://codereview.chromium.org/261363002/diff/1/content/browser/browser_plugin/browser_plugin_embedder.h File content/browser/browser_plugin/browser_plugin_embedder.h (right): https://codereview.chromium.org/261363002/diff/1/content/browser/browser_plugin/browser_plugin_embedder.h#newcode35 content/browser/browser_plugin/browser_plugin_embedder.h:35: class BrowserPluginGuestManager; ...
6 years, 7 months ago (2014-05-07 19:01:50 UTC) #3
jam
lgtm https://codereview.chromium.org/261363002/diff/20001/content/browser/browser_plugin/test_guest_manager.cc File content/browser/browser_plugin/test_guest_manager.cc (right): https://codereview.chromium.org/261363002/diff/20001/content/browser/browser_plugin/test_guest_manager.cc#newcode22 content/browser/browser_plugin/test_guest_manager.cc:22: : public content::WebContentsObserver { ditto https://codereview.chromium.org/261363002/diff/20001/content/browser/browser_plugin/test_guest_manager.h File content/browser/browser_plugin/test_guest_manager.h ...
6 years, 7 months ago (2014-05-07 19:38:09 UTC) #4
Fady Samuel
Addressed nits. CQ'ing now. https://codereview.chromium.org/261363002/diff/20001/content/browser/browser_plugin/test_guest_manager.cc File content/browser/browser_plugin/test_guest_manager.cc (right): https://codereview.chromium.org/261363002/diff/20001/content/browser/browser_plugin/test_guest_manager.cc#newcode22 content/browser/browser_plugin/test_guest_manager.cc:22: : public content::WebContentsObserver { On ...
6 years, 7 months ago (2014-05-11 02:40:26 UTC) #5
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 7 months ago (2014-05-11 02:45:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/261363002/60001
6 years, 7 months ago (2014-05-11 02:45:34 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-11 04:44:32 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-11 04:59:15 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/182668)
6 years, 7 months ago (2014-05-11 04:59:15 UTC) #10
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 7 months ago (2014-05-11 11:44:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/261363002/80001
6 years, 7 months ago (2014-05-11 11:44:26 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-11 14:21:38 UTC) #13
Message was sent while issue was closed.
Change committed as 269705

Powered by Google App Engine
This is Rietveld 408576698