Fix blank NTP bug on Clank.

Fix blank NTP bug on Clank.

This was a result of the FRE refactor work for first run experiments,
which had moved FirstRunActivity creation to be before native init.
As a result of that, the removeBackground() ChromeTabbedActivity ended
up happening when the activity was not foreground, which apparently
caused the bug.

This change fixes it by making the removeBackground() call happen
later, when the ChromeTabbedActivity is visible. The logic is such
that we do it once both native init and window focus events have
been received.

BUG=673831
Committed: https://crrev.com/928bfdc6404ea14bc71c28ef3e483453c34d0c52
Cr-Commit-Position: refs/heads/master@{#441378}

[Alexei Svitkine (slow), 2017-01-03 23:23:27]

Patchset #1 (id:1) has been deleted

[Alexei Svitkine (slow), 2017-01-03 23:23:46]

asvitkine@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Alexei Svitkine (slow), 2017-01-03 23:23:50]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 23:24:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 00:25:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 00:25:51]

Dry run: This issue passed the CQ dry run.

[Ted C, 2017-01-04 00:30:04]

lgtm

https://codereview.chromium.org/2613573003/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://codereview.chromium.org/2613573003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:1047:
private void possiblyRemoveWindowBackground() {
tiniest of nits, but I think we use "maybe" instead of "possibly" more often to
represent this concept in java.

[Alexei Svitkine (slow), 2017-01-04 15:09:36]

https://codereview.chromium.org/2613573003/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://codereview.chromium.org/2613573003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:1047:
private void possiblyRemoveWindowBackground() {
On 2017/01/04 00:30:04, Ted C wrote:
> tiniest of nits, but I think we use "maybe" instead of "possibly" more often
to
> represent this concept in java.

Done.

[Alexei Svitkine (slow), 2017-01-04 15:09:39]

The CQ bit was checked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2017-01-04 15:09:39]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2613573003/#ps40001
(title: "Address nit.")

[commit-bot: I haz the power, 2017-01-04 15:09:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 15:42:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483542579134640,
"parent_rev": "33dc4240b9e726e95dd733283c92f4f6c3f6d326", "commit_rev":
"f6f56907cf3a83859149613237be593cfb63b4e5"}

[commit-bot: I haz the power, 2017-01-04 15:42:54]

Description was changed from

==========
Fix blank NTP bug on Clank.

This was a result of the FRE refactor work for first run experiments,
which had moved FirstRunActivity creation to be before native init.
As a result of that, the removeBackground() ChromeTabbedActivity ended
up happening when the activity was not foreground, which apparently
caused the bug.

This change fixes it by making the removeBackground() call happen
later, when the ChromeTabbedActivity is visible. The logic is such
that we do it once both native init and window focus events have
been received.

BUG=673831
==========

to

==========
Fix blank NTP bug on Clank.

This was a result of the FRE refactor work for first run experiments,
which had moved FirstRunActivity creation to be before native init.
As a result of that, the removeBackground() ChromeTabbedActivity ended
up happening when the activity was not foreground, which apparently
caused the bug.

This change fixes it by making the removeBackground() call happen
later, when the ChromeTabbedActivity is visible. The logic is such
that we do it once both native init and window focus events have
been received.

BUG=673831

Review-Url: https://codereview.chromium.org/2613573003
==========

[commit-bot: I haz the power, 2017-01-04 15:42:55]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2017-01-04 15:45:37]

Description was changed from

==========
Fix blank NTP bug on Clank.

This was a result of the FRE refactor work for first run experiments,
which had moved FirstRunActivity creation to be before native init.
As a result of that, the removeBackground() ChromeTabbedActivity ended
up happening when the activity was not foreground, which apparently
caused the bug.

This change fixes it by making the removeBackground() call happen
later, when the ChromeTabbedActivity is visible. The logic is such
that we do it once both native init and window focus events have
been received.

BUG=673831

Review-Url: https://codereview.chromium.org/2613573003
==========

to

==========
Fix blank NTP bug on Clank.

This was a result of the FRE refactor work for first run experiments,
which had moved FirstRunActivity creation to be before native init.
As a result of that, the removeBackground() ChromeTabbedActivity ended
up happening when the activity was not foreground, which apparently
caused the bug.

This change fixes it by making the removeBackground() call happen
later, when the ChromeTabbedActivity is visible. The logic is such
that we do it once both native init and window focus events have
been received.

BUG=673831

Committed: https://crrev.com/928bfdc6404ea14bc71c28ef3e483453c34d0c52
Cr-Commit-Position: refs/heads/master@{#441378}
==========

[commit-bot: I haz the power, 2017-01-04 15:45:38]

Patchset 2 (id:??) landed as
https://crrev.com/928bfdc6404ea14bc71c28ef3e483453c34d0c52
Cr-Commit-Position: refs/heads/master@{#441378}