Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 2613543002: Turn off VrShell experiment in testing config. (Closed)

Created:
3 years, 11 months ago by liberato (no reviews please)
Modified:
3 years, 11 months ago
Reviewers:
rkaplow, amp
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn off VrShell experiment in testing config. Don't enable VrShell experiment in non-channel builds, since it turns off overlay support for video playback on Android. Enabling tests is blocked on supporting overlay video properly anyway, so nothing depends on this default. BUG=678018 Committed: https://crrev.com/7345d7850f8c96020a2a43792b699b70093e9ac4 Cr-Commit-Position: refs/heads/master@{#441272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M testing/variations/fieldtrial_testing_config.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
liberato (no reviews please)
3 years, 11 months ago (2017-01-03 18:44:00 UTC) #3
amp
LGTM. Thanks for figuring this out. I also added a comment to the related bug ...
3 years, 11 months ago (2017-01-03 18:48:07 UTC) #4
rkaplow
lgtm LG but the field trial should then be turned down
3 years, 11 months ago (2017-01-03 21:05:12 UTC) #5
amp
On 2017/01/03 21:05:12, rkaplow wrote: > lgtm > > LG but the field trial should ...
3 years, 11 months ago (2017-01-03 21:22:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613543002/1
3 years, 11 months ago (2017-01-03 23:16:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 00:54:56 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 00:56:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7345d7850f8c96020a2a43792b699b70093e9ac4
Cr-Commit-Position: refs/heads/master@{#441272}

Powered by Google App Engine
This is Rietveld 408576698