Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2613533003: Tap suppression controller forwards the next TapCancel when the stashed TapDown is forwarded. (Closed)

Created:
3 years, 11 months ago by sahel
Modified:
3 years, 11 months ago
Reviewers:
tdresser
CC:
chromium-reviews, jam, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tap suppression controller forwards the next TapCancel when the stashed TapDown is forwarded. When the controller forwards the stashed TapDown event after tapDownTimer expiration, it should forward the next TapCancel event as well to maintain a valid input stream. The rest of the tap ending events should get suppressed till the next TapDown event. BUG=674602 TEST=TapSuppressionControllerTest.GFCAckBeforeTapSufficientlyLateTapCancel Committed: https://crrev.com/4a0c0947e7f0432e2810c3b008f17a9136c4518f Cr-Commit-Position: refs/heads/master@{#441396}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -2 lines) Patch
M content/browser/renderer_host/input/tap_suppression_controller_unittest.cc View 3 chunks +47 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/touchscreen_tap_suppression_controller.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/touchscreen_tap_suppression_controller.cc View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
sahel
3 years, 11 months ago (2017-01-04 15:36:26 UTC) #7
tdresser
LGTM!
3 years, 11 months ago (2017-01-04 16:39:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613533003/1
3 years, 11 months ago (2017-01-04 16:41:56 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 16:46:59 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 16:50:44 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a0c0947e7f0432e2810c3b008f17a9136c4518f
Cr-Commit-Position: refs/heads/master@{#441396}

Powered by Google App Engine
This is Rietveld 408576698