Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2613473002: bluetooth: bluez: Implement BluetoothRemoteGattCharacteristicBluez::SubscribeToNotifications and Un… (Closed)

Created:
3 years, 11 months ago by perja
Modified:
3 years, 11 months ago
Reviewers:
scheib
CC:
chromium-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: bluez: Implement BluetoothRemoteGattCharacteristicBluez::SubscribeToNotifications and UnsubscribeFromNotifications. BUG=636275 Committed: https://crrev.com/130fb78147f08bce3ef210937bf00e34dd8ea91d Cr-Commit-Position: refs/heads/master@{#441456}

Patch Set 1 #

Patch Set 2 : Also include Chrome OS as it uses Bluez. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -182 lines) Patch
M device/bluetooth/bluetooth_remote_gatt_characteristic.cc View 1 4 chunks +6 lines, -16 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_gatt_bluez_unittest.cc View 8 chunks +24 lines, -4 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_remote_gatt_characteristic_bluez.h View 3 chunks +3 lines, -21 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_remote_gatt_characteristic_bluez.cc View 8 chunks +28 lines, -141 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
perja
@scheib: PTAL.
3 years, 11 months ago (2017-01-04 12:15:46 UTC) #10
scheib
LGTM
3 years, 11 months ago (2017-01-04 20:38:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613473002/20001
3 years, 11 months ago (2017-01-04 20:39:04 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-04 20:44:06 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 20:45:54 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/130fb78147f08bce3ef210937bf00e34dd8ea91d
Cr-Commit-Position: refs/heads/master@{#441456}

Powered by Google App Engine
This is Rietveld 408576698