Support generic methods in reflection.

Support generic methods in reflection.

Closes #28240

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/72e3e0c0069d2f7aff8e5353f64ca95e6ae3e063

[Johnni Winther, 2017-01-03 13:50:18]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-01-03 18:58:13]

lgtm, with comments

https://codereview.chromium.org/2613433002/diff/20001/sdk/lib/_internal/js_ru...
File sdk/lib/_internal/js_runtime/lib/js_helper.dart (right):

https://codereview.chromium.org/2613433002/diff/20001/sdk/lib/_internal/js_ru...
sdk/lib/_internal/js_runtime/lib/js_helper.dart:682: if (jsConstructor != null)
{
can you give me some extra details of when this happens? In particular, this
seems to handle more than just generics, or do we only expect functionType to be
a function if it has generic arguments?

[Johnni Winther, 2017-01-04 09:15:39]

https://codereview.chromium.org/2613433002/diff/20001/sdk/lib/_internal/js_ru...
File sdk/lib/_internal/js_runtime/lib/js_helper.dart (right):

https://codereview.chromium.org/2613433002/diff/20001/sdk/lib/_internal/js_ru...
sdk/lib/_internal/js_runtime/lib/js_helper.dart:682: if (jsConstructor != null)
{
On 2017/01/03 18:58:13, Siggi Cherem (dart-lang) wrote:
> can you give me some extra details of when this happens? In particular, this
> seems to handle more than just generics, or do we only expect functionType to
be
> a function if it has generic arguments?

It was provoked by lrn's landing of https://codereview.chromium.org/2529393002

This introduces function types the should not be substituted by the type
arguments of the current class which is what is now handled here. 

The change here corresponds to the change in js_helper.dart in
https://codereview.chromium.org/2565413002/

[Johnni Winther, 2017-01-04 09:32:25]

Description was changed from

==========
Support generic methods in reflection.

Closes #28240
==========

to

==========
Support generic methods in reflection.

Closes #28240

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/72e3e0c0069d2f7aff8e5353f64ca95e6ae3e063
==========

[Johnni Winther, 2017-01-04 09:32:26]

Committed patchset #2 (id:20001) manually as
72e3e0c0069d2f7aff8e5353f64ca95e6ae3e063 (presubmit successful).