Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2529393002: Make core libraries use generic method syntax. (Closed)

Created:
4 years ago by Lasse Reichstein Nielsen
Modified:
3 years, 11 months ago
Reviewers:
floitsch, eernst
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make core libraries use generic method syntax. Removes comment syntax where possible for the following platform libraries: * async * collection * convert * core * internal * io * math The HTML related libraries are not changed. The templates used to build them must be changed as well. R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/68818315b5cc6c63fea0e10e90f515f6083ec095 Committed: https://github.com/dart-lang/sdk/commit/3f74b8d82edca8c342c43306714e68ddf84548e1 Committed: https://github.com/dart-lang/sdk/commit/44594277e16f2b523eae8c8bc9ac60fd09bb930a

Patch Set 1 #

Patch Set 2 : Revert change in ... LineSplitter. No surprise there. Fix bug in test and bad whitespace. #

Patch Set 3 : We have a generic patch function. #

Patch Set 4 : Merge to head #

Total comments: 19

Patch Set 5 : Address comments. #

Patch Set 6 : Fix function fingerprints for VM. Change LineSplitter. #

Total comments: 1

Patch Set 7 : Change chunked conversion back. #

Total comments: 20

Patch Set 8 : Fix line-breaking. #

Patch Set 9 : Update test expectations. #

Patch Set 10 : Update status files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+942 lines, -282 lines) Patch
M pkg/pkg.status View 1 2 3 4 5 6 7 8 9 2 chunks +288 lines, -0 lines 0 comments Download
M runtime/lib/convert_patch.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/service.status View 1 2 3 4 5 6 7 8 9 1 chunk +120 lines, -0 lines 0 comments Download
M runtime/vm/method_recognizer.h View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/convert_patch.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/async/async_error.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/async/broadcast_stream_controller.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/async/future.dart View 1 2 3 5 6 chunks +11 lines, -11 lines 0 comments Download
M sdk/lib/async/future_impl.dart View 4 chunks +17 lines, -17 lines 0 comments Download
M sdk/lib/async/stream.dart View 11 chunks +27 lines, -27 lines 0 comments Download
M sdk/lib/async/stream_controller.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/async/stream_impl.dart View 8 chunks +12 lines, -12 lines 0 comments Download
M sdk/lib/async/timer.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/async/zone.dart View 1 2 3 43 chunks +110 lines, -110 lines 0 comments Download
M sdk/lib/collection/iterable.dart View 5 2 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/collection/list.dart View 5 3 chunks +7 lines, -7 lines 0 comments Download
M sdk/lib/collection/queue.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/set.dart View 1 5 3 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/convert/chunked_conversion.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/convert/codec.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/convert/converter.dart View 1 2 3 4 5 6 7 3 chunks +5 lines, -6 lines 0 comments Download
M sdk/lib/convert/json.dart View 1 2 3 4 6 7 1 chunk +2 lines, -3 lines 0 comments Download
M sdk/lib/convert/line_splitter.dart View 1 2 3 4 5 6 7 8 9 3 chunks +3 lines, -2 lines 0 comments Download
M sdk/lib/convert/utf.dart View 1 2 3 4 6 7 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/core/iterable.dart View 1 2 3 4 5 6 7 3 chunks +4 lines, -6 lines 0 comments Download
M sdk/lib/internal/iterable.dart View 1 2 3 4 5 6 7 4 chunks +5 lines, -11 lines 0 comments Download
M sdk/lib/internal/sort.dart View 1 2 3 4 5 6 7 5 chunks +8 lines, -7 lines 0 comments Download
M sdk/lib/io/file_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/http_impl.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/io/http_parser.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/io/link.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/secure_socket.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/io/websocket_impl.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/math/math.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/math/rectangle.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M tests/benchmark_smoke/benchmark_smoke.status View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -0 lines 0 comments Download
M tests/html/html.status View 1 2 3 4 5 6 7 8 9 1 chunk +157 lines, -0 lines 0 comments Download
M tests/isolate/isolate.status View 1 2 3 4 5 6 7 8 9 1 chunk +31 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 2 3 4 5 6 7 8 9 1 chunk +6 lines, -0 lines 0 comments Download
M tests/lib/convert/chunked_conversion1_test.dart View 1 2 3 4 5 6 7 8 6 chunks +10 lines, -8 lines 0 comments Download
M tests/lib/lib.status View 1 2 3 4 5 6 7 8 9 1 chunk +42 lines, -0 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 3 4 5 6 7 8 9 1 chunk +13 lines, -0 lines 0 comments Download
M tests/utils/utils.status View 1 2 3 4 5 6 7 8 9 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
Lasse Reichstein Nielsen
4 years ago (2016-11-28 14:06:09 UTC) #2
Lasse Reichstein Nielsen
4 years ago (2016-12-13 10:39:34 UTC) #4
Lasse Reichstein Nielsen
This can now land, PTAL
4 years ago (2016-12-13 12:16:20 UTC) #5
floitsch
LGTM. https://codereview.chromium.org/2529393002/diff/60001/sdk/lib/collection/iterable.dart File sdk/lib/collection/iterable.dart (right): https://codereview.chromium.org/2529393002/diff/60001/sdk/lib/collection/iterable.dart#newcode49 sdk/lib/collection/iterable.dart:49: T fold<T>(T initialValue, Does this fit on one ...
4 years ago (2016-12-13 12:42:25 UTC) #6
Lasse Reichstein Nielsen
https://codereview.chromium.org/2529393002/diff/60001/sdk/lib/collection/iterable.dart File sdk/lib/collection/iterable.dart (right): https://codereview.chromium.org/2529393002/diff/60001/sdk/lib/collection/iterable.dart#newcode49 sdk/lib/collection/iterable.dart:49: T fold<T>(T initialValue, On 2016/12/13 12:42:24, floitsch wrote: > ...
4 years ago (2016-12-13 14:28:03 UTC) #7
Lasse Reichstein Nielsen
Committed patchset #5 (id:80001) manually as 68818315b5cc6c63fea0e10e90f515f6083ec095 (presubmit successful).
4 years ago (2016-12-14 10:34:57 UTC) #9
Lasse Reichstein Nielsen
Committed patchset #5 (id:80001) manually as 3f74b8d82edca8c342c43306714e68ddf84548e1 (presubmit successful).
4 years ago (2016-12-14 11:25:17 UTC) #11
Lasse Reichstein Nielsen
Reverted again. Found errors in VM function hash codes, kernel compilation, dart2js compilation and some ...
4 years ago (2016-12-14 11:35:52 UTC) #13
Lasse Reichstein Nielsen
PTAL on LineSplitter. https://codereview.chromium.org/2529393002/diff/100001/sdk/lib/convert/line_splitter.dart File sdk/lib/convert/line_splitter.dart (right): https://codereview.chromium.org/2529393002/diff/100001/sdk/lib/convert/line_splitter.dart#newcode20 sdk/lib/convert/line_splitter.dart:20: class LineSplitter implements StreamTransformer<String, String> { ...
4 years ago (2016-12-16 16:36:01 UTC) #14
floitsch
LGTM. https://codereview.chromium.org/2529393002/diff/120001/sdk/lib/convert/converter.dart File sdk/lib/convert/converter.dart (right): https://codereview.chromium.org/2529393002/diff/120001/sdk/lib/convert/converter.dart#newcode27 sdk/lib/convert/converter.dart:27: Converter<S, TT> fuse<TT>( Should fit on the same ...
4 years ago (2016-12-19 19:14:46 UTC) #15
Lasse Reichstein Nielsen
https://codereview.chromium.org/2529393002/diff/120001/sdk/lib/convert/converter.dart File sdk/lib/convert/converter.dart (right): https://codereview.chromium.org/2529393002/diff/120001/sdk/lib/convert/converter.dart#newcode27 sdk/lib/convert/converter.dart:27: Converter<S, TT> fuse<TT>( On 2016/12/19 19:14:45, floitsch wrote: > ...
3 years, 11 months ago (2017-01-03 10:33:20 UTC) #16
Lasse Reichstein Nielsen
3 years, 11 months ago (2017-01-03 11:05:46 UTC) #18
Message was sent while issue was closed. 
Committed patchset #10 (id:180001) manually as
44594277e16f2b523eae8c8bc9ac60fd09bb930a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698