Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2613383002: arc: Use ARC_GET_INSTANCE_FOR_METHOD for getting app instance (Closed)

Created:
3 years, 11 months ago by Yusuke Sato
Modified:
3 years, 11 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, Matt Giuca
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Use ARC_GET_INSTANCE_FOR_METHOD for getting app instance This is safer than manually specifying min versions. BUG=649782 TEST=git try, ARC still works Review-Url: https://codereview.chromium.org/2613383002 Cr-Commit-Position: refs/heads/master@{#442295} Committed: https://chromium.googlesource.com/chromium/src/+/d0c37cba3d84dc551c4d4b98a3dcf23321ed4b17

Patch Set 1 #

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -69 lines) Patch
M chrome/browser/ui/app_list/arc/arc_app_utils.cc View 1 11 chunks +31 lines, -69 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Yusuke Sato
PTAL too. Once this is landed, I think we can rename GetInstanceForVersion() to something like ...
3 years, 11 months ago (2017-01-07 01:31:10 UTC) #4
Yusuke Sato
+xiyuan for owner review. Please have a look. We're trying to stop specifying mojo interface ...
3 years, 11 months ago (2017-01-07 02:00:35 UTC) #8
xiyuan
lgtm
3 years, 11 months ago (2017-01-09 17:18:59 UTC) #11
Luis Héctor Chávez
On 2017/01/07 01:31:10, Yusuke Sato wrote: > PTAL too. > > Once this is landed, ...
3 years, 11 months ago (2017-01-09 17:23:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613383002/20001
3 years, 11 months ago (2017-01-09 17:43:07 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 18:21:24 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d0c37cba3d84dc551c4d4b98a3dc...

Powered by Google App Engine
This is Rietveld 408576698