Allow a View to specify a non-default native theme (i.e. different from

Allow a View to specify a non-default native theme (i.e. different from
that of its Widget).

Apply this in the case of infobars.

BUG=648381
Review-Url: https://codereview.chromium.org/2613343002
Cr-Commit-Position: refs/heads/master@{#442319}
Committed: https://chromium.googlesource.com/chromium/src/+/49aa74f940257565de95367b42c76208cb37d837

[Evan Stade, 2017-01-06 21:30:42]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2017-01-06 21:30:49]

Description was changed from

==========
Allow a view to specify a non-default native theme (i.e. different from
that of its Widget).

Apply this in the case of infobars.

BUG=648381
==========

to

==========
Allow a View to specify a non-default native theme (i.e. different from
that of its Widget).

Apply this in the case of infobars.

BUG=648381
==========

[Evan Stade, 2017-01-06 21:30:49]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[commit-bot: I haz the power, 2017-01-06 21:31:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 22:38:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 22:38:17]

Dry run: This issue passed the CQ dry run.

[sky, 2017-01-09 16:13:52]

https://codereview.chromium.org/2613343002/diff/20001/ui/views/view.h
File ui/views/view.h (right):

https://codereview.chromium.org/2613343002/diff/20001/ui/views/view.h#newcode551
ui/views/view.h:551: // Sets the native theme override and informs descendants.
I'm not sure 'override' buys much here. How about SetNativeTheme ? Similar
comment for the member name, native_theme_ is fine.

[Evan Stade, 2017-01-09 17:36:26]

https://codereview.chromium.org/2613343002/diff/20001/ui/views/view.h
File ui/views/view.h (right):

https://codereview.chromium.org/2613343002/diff/20001/ui/views/view.h#newcode551
ui/views/view.h:551: // Sets the native theme override and informs descendants.
On 2017/01/09 16:13:52, sky wrote:
> I'm not sure 'override' buys much here. How about SetNativeTheme ? Similar
> comment for the member name, native_theme_ is fine.

Done.

[sky, 2017-01-09 18:07:58]

LGTM

[Evan Stade, 2017-01-09 18:40:38]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2017-01-09 18:41:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-09 20:00:21]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483987238015390,
"parent_rev": "01bf23e7e27102560b44f1353d8f55e6dd62457a", "commit_rev":
"49aa74f940257565de95367b42c76208cb37d837"}

[commit-bot: I haz the power, 2017-01-09 20:00:49]

Description was changed from

==========
Allow a View to specify a non-default native theme (i.e. different from
that of its Widget).

Apply this in the case of infobars.

BUG=648381
==========

to

==========
Allow a View to specify a non-default native theme (i.e. different from
that of its Widget).

Apply this in the case of infobars.

BUG=648381

Review-Url: https://codereview.chromium.org/2613343002
Cr-Commit-Position: refs/heads/master@{#442319}
Committed:
https://chromium.googlesource.com/chromium/src/+/49aa74f940257565de95367b42c7...
==========

[commit-bot: I haz the power, 2017-01-09 20:00:50]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/49aa74f940257565de95367b42c7...