Forward ImeCancelComposition calls for OOPIFs to ImeAdapterAndroid

Forward ImeCancelComposition calls for OOPIFs to ImeAdapterAndroid

Currently, only the calls to ImeCancelComposition on the tab's view
(RenderWidgetHostViewAndroid) are being forwarded to ImeAdpaterAndroid.
This CL will pass such calls for all views onto TextInputManager
and notifies the RWHVAndroid to forward the call to IME adapter.

BUG=578168
Review-Url: https://codereview.chromium.org/2613263002
Cr-Commit-Position: refs/heads/master@{#444133}
Committed: https://chromium.googlesource.com/chromium/src/+/36c024e17a7c80294abbf2805d10635e2e3d9287

[EhsanK, 2017-01-14 07:00:58]

The CQ bit was checked by ekaramad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-14 07:01:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[EhsanK, 2017-01-14 07:04:09]

Description was changed from

==========
Forward ImeCancelComposition calls for OOPIFs to ImeAdapterAndroid

Currently, only the calls to ImeCancelComposition on the tab's view
(RenderWidgetHostViewAndroid) are being forwarded to ImeAdpaterAndroid.
This CL will route such calls for all views through TextInputManager
and notifies the RWHVAndroid to forward the call to IME adapter.

BUG=578168
==========

to

==========
Forward ImeCancelComposition calls for OOPIFs to ImeAdapterAndroid

Currently, only the calls to ImeCancelComposition on the tab's view
(RenderWidgetHostViewAndroid) are being forwarded to ImeAdpaterAndroid.
This CL will pass such calls for all views onto TextInputManager
and notifies the RWHVAndroid to forward the call to IME adapter.

BUG=578168
==========

[commit-bot: I haz the power, 2017-01-14 07:50:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-14 07:50:11]

Dry run: This issue passed the CQ dry run.

[EhsanK, 2017-01-14 09:24:20]

ekaramad@chromium.org changed reviewers:
+ creis@chromium.org

[EhsanK, 2017-01-14 09:24:21]

Charlie, could you please take a look?

[Charlie Reis, 2017-01-17 19:24:58]

[+site-isolation-reviews]

LGTM.  Are there any tests this allows us to re-enable?

[EhsanK, 2017-01-17 19:30:36]

Thanks! Unfortunately, we only seem to have a unit test for this and that is on
Mac (render_widget_host_view_mac_unittest.mm).

I do not know of a similar test location for Android. And I think we might have
missed aura since I don't see why we do not have the same unit test in
render_widget_host_view_aura_unittest.cc.

[Charlie Reis, 2017-01-17 19:36:17]

On 2017/01/17 19:30:36, EhsanK wrote:
> Thanks! Unfortunately, we only seem to have a unit test for this and that is
on
> Mac (render_widget_host_view_mac_unittest.mm).
> 
> I do not know of a similar test location for Android. And I think we might
have
> missed aura since I don't see why we do not have the same unit test in
> render_widget_host_view_aura_unittest.cc.

Ok.  Feel free to proceed since it's minor, but let's think about whether we can
get test coverage on the other platforms.

[EhsanK, 2017-01-17 19:50:24]

The CQ bit was checked by ekaramad@chromium.org

[commit-bot: I haz the power, 2017-01-17 19:51:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 20:47:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484682624300570,
"parent_rev": "4a286ed6b9406edfb1031ae1d48766f79652a6ca", "commit_rev":
"36c024e17a7c80294abbf2805d10635e2e3d9287"}

[commit-bot: I haz the power, 2017-01-17 20:47:59]

Description was changed from

==========
Forward ImeCancelComposition calls for OOPIFs to ImeAdapterAndroid

Currently, only the calls to ImeCancelComposition on the tab's view
(RenderWidgetHostViewAndroid) are being forwarded to ImeAdpaterAndroid.
This CL will pass such calls for all views onto TextInputManager
and notifies the RWHVAndroid to forward the call to IME adapter.

BUG=578168
==========

to

==========
Forward ImeCancelComposition calls for OOPIFs to ImeAdapterAndroid

Currently, only the calls to ImeCancelComposition on the tab's view
(RenderWidgetHostViewAndroid) are being forwarded to ImeAdpaterAndroid.
This CL will pass such calls for all views onto TextInputManager
and notifies the RWHVAndroid to forward the call to IME adapter.

BUG=578168

Review-Url: https://codereview.chromium.org/2613263002
Cr-Commit-Position: refs/heads/master@{#444133}
Committed:
https://chromium.googlesource.com/chromium/src/+/36c024e17a7c80294abbf2805d10...
==========

[commit-bot: I haz the power, 2017-01-17 20:48:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/36c024e17a7c80294abbf2805d10...