Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2613193002: [wasm] Decoder had 2 representations for "end". (Closed)

Created:
3 years, 11 months ago by Mircea Trofin
Modified:
3 years, 11 months ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Decoder had 2 representations for "end". Removing "limit_", using just "end_". BUG= Review-Url: https://codereview.chromium.org/2613193002 Cr-Commit-Position: refs/heads/master@{#42105} Committed: https://chromium.googlesource.com/v8/v8/+/a6402fd91667fbb955e5f990c70e09c32770ecea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -29 lines) Patch
M src/wasm/decoder.h View 9 chunks +9 lines, -12 lines 0 comments Download
M src/wasm/function-body-decoder.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M src/wasm/module-decoder.cc View 6 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Mircea Trofin
3 years, 11 months ago (2017-01-06 04:23:33 UTC) #5
bradnelson
lgtm
3 years, 11 months ago (2017-01-06 08:00:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613193002/1
3 years, 11 months ago (2017-01-06 08:00:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/a6402fd91667fbb955e5f990c70e09c32770ecea
3 years, 11 months ago (2017-01-06 08:02:17 UTC) #13
titzer
On 2017/01/06 08:02:17, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 11 months ago (2017-01-09 18:34:46 UTC) #14
Mircea Trofin
3 years, 11 months ago (2017-01-09 19:00:17 UTC) #15
Message was sent while issue was closed.
On 2017/01/09 18:34:46, titzer wrote:
> On 2017/01/06 08:02:17, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
>
https://chromium.googlesource.com/v8/v8/+/a6402fd91667fbb955e5f990c70e09c3277...
> 
> There was a good reason for {limit} being separate from {end}. {limit} is
> checked in decoding loops and is reset when an error occurs, terminating
> decoding loops, whereas {end} always points to the end of the bytes, and
should
> never change.

What scenario would we want to support with that separation, and what should the
test be?

Powered by Google App Engine
This is Rietveld 408576698