Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2613183002: Revert of Multiprocess test client: Android child process launcher rework. (Closed)

Created:
3 years, 11 months ago by Jay Civelli
Modified:
3 years, 11 months ago
CC:
Aaron Boodman, abarth-chromium, agrieve+watch_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, vmpstr+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Multiprocess test client: Android child process launcher rework. (patchset #21 id:400001 of https://codereview.chromium.org/2549363004/ ) Reason for revert: Breaks build on Android Cronet ARM64 Builder (dbg) Original issue's description: > Multiprocess test client: Android child process launcher rework. > > Changing the way test start child processese on Android. > Forking natively should not be used on Andoid, instead child processes > should be started through the Android framework, which requires going > to Java and using Android services. > > For that we introduce the MultiprocessTestClientLauncher java class > which starts a service in a new process. We provide several > MultiprocessTestClientService service classes to ensure we can have > multiple child processes. > File descriptor are passed from the parent to the child process as > Parcelable, and we use the GlobalDescriptors class to register them. > > TEST=Run the mojo_system_unittests > BUG=666356 > > Review-Url: https://codereview.chromium.org/2549363004 > Cr-Commit-Position: refs/heads/master@{#441799} > Committed: https://chromium.googlesource.com/chromium/src/+/5513e4622febbc838dfebddb51347ab797747836 TBR=rockot@chromium.org,nyquist@chromium.org,boliu@chromium.org,thakis@chromium.org,dpranke@chromium.org,sdefresne@chromium.org,dcheng@chromium.org,rsesek@chromium.org,eroman@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=666356 Review-Url: https://codereview.chromium.org/2613183002 Cr-Commit-Position: refs/heads/master@{#441825} Committed: https://chromium.googlesource.com/chromium/src/+/8f2c67087919621e412ac9a5e82a2e719de80362

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+522 lines, -1073 lines) Patch
M android_webview/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M base/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
M base/debug/proc_maps_linux_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M base/files/file_locking_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M base/posix/global_descriptors.h View 1 chunk +11 lines, -0 lines 0 comments Download
M base/process/process.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/process/process_posix.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/process/process_util_unittest.cc View 3 chunks +15 lines, -6 lines 0 comments Download
M base/process/process_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/test/BUILD.gn View 5 chunks +4 lines, -67 lines 0 comments Download
D base/test/android/java/src/org/chromium/base/FileDescriptorInfo.aidl View 1 chunk +0 lines, -7 lines 0 comments Download
D base/test/android/java/src/org/chromium/base/FileDescriptorInfo.java View 1 chunk +0 lines, -58 lines 0 comments Download
D base/test/android/java/src/org/chromium/base/ITestClient.aidl View 1 chunk +0 lines, -45 lines 0 comments Download
D base/test/android/java/src/org/chromium/base/MainReturnCodeResult.aidl View 1 chunk +0 lines, -7 lines 0 comments Download
D base/test/android/java/src/org/chromium/base/MainReturnCodeResult.java View 1 chunk +0 lines, -64 lines 0 comments Download
D base/test/android/java/src/org/chromium/base/MultiprocessTestClientLauncher.java View 1 chunk +0 lines, -293 lines 0 comments Download
D base/test/android/java/src/org/chromium/base/MultiprocessTestClientService.java View 1 chunk +0 lines, -147 lines 0 comments Download
D base/test/android/java/src/org/chromium/base/MultiprocessTestClientService0.java View 1 chunk +0 lines, -10 lines 0 comments Download
D base/test/android/java/src/org/chromium/base/MultiprocessTestClientService1.java View 1 chunk +0 lines, -10 lines 0 comments Download
D base/test/android/java/src/org/chromium/base/MultiprocessTestClientService2.java View 1 chunk +0 lines, -10 lines 0 comments Download
D base/test/android/java/src/org/chromium/base/MultiprocessTestClientService3.java View 1 chunk +0 lines, -10 lines 0 comments Download
D base/test/android/java/src/org/chromium/base/MultiprocessTestClientService4.java View 1 chunk +0 lines, -10 lines 0 comments Download
D base/test/android/multiprocess_test_client_service.h View 1 chunk +0 lines, -18 lines 0 comments Download
D base/test/android/multiprocess_test_client_service.cc View 1 chunk +0 lines, -59 lines 0 comments Download
D base/test/android/test_support_jni_registrar.h View 1 chunk +0 lines, -21 lines 0 comments Download
D base/test/android/test_support_jni_registrar.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D base/test/main_stub.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M base/test/multiprocess_test.h View 3 chunks +18 lines, -15 lines 0 comments Download
M base/test/multiprocess_test.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M base/test/multiprocess_test_android.cc View 1 chunk +429 lines, -65 lines 0 comments Download
M base/test/test_support_android.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M build/android/pylib/gtest/gtest_test_instance.py View 1 chunk +1 line, -10 lines 0 comments Download
M components/test_runner/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/memory/memory_coordinator_impl_unittest.cc View 1 chunk +1 line, -8 lines 0 comments Download
M content/shell/android/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M ipc/run_all_unittests.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/android/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/edk/embedder/platform_channel_pair.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/embedder/platform_channel_pair_posix.cc View 5 chunks +1 line, -26 lines 0 comments Download
M mojo/edk/test/multiprocess_test_helper.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M mojo/edk/test/run_all_perftests.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/edk/test/run_all_unittests.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M testing/android/native_test/java/AndroidManifest.xml.jinja2 View 1 chunk +0 lines, -12 lines 0 comments Download
M testing/android/native_test/native_test_launcher.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M testing/test.gni View 3 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jay Civelli
Created Revert of Multiprocess test client: Android child process launcher rework.
3 years, 11 months ago (2017-01-06 02:15:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613183002/1
3 years, 11 months ago (2017-01-06 02:16:12 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 02:18:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8f2c67087919621e412ac9a5e82a...

Powered by Google App Engine
This is Rietveld 408576698