Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2613153007: Fix race in treapstore test. (Closed)

Created:
3 years, 11 months ago by dnj
Modified:
3 years, 11 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Fix race in treapstore test. The treapstore test currently asserts that at least one read happens. The first round, however, it is possible that no writes happen before the read round finishes. Adjust the test to accommodate this. The check itself is not very useful. The purpose of this test is to expose a bunch of potential races and assert that they aren't actually races. TBR=vadimsh@chromium.org BUG=chromium:675485 TEST=local - for i in `seq 100`; do go test -cpu=1,2,4 ./common/data/treapstore; done Review-Url: https://codereview.chromium.org/2613153007 Committed: https://github.com/luci/luci-go/commit/a675724fae898cba8386a64186ad75b71730c393

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M common/data/treapstore/store_test.go View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
dnj
3 years, 11 months ago (2017-01-07 02:32:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613153007/1
3 years, 11 months ago (2017-01-07 02:32:44 UTC) #3
Vadim Sh.
lgtm
3 years, 11 months ago (2017-01-07 02:33:55 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-07 02:39:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/a675724fae898cba8386a64186ad75b71730c393

Powered by Google App Engine
This is Rietveld 408576698