Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2613143002: use unique_ptr in xfa_checksum.h (Closed)

Created:
3 years, 11 months ago by Tom Sepez
Modified:
3 years, 11 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
M xfa/fxfa/app/xfa_checksum.cpp View 4 chunks +13 lines, -16 lines 0 comments Download
M xfa/fxfa/xfa_checksum.h View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Tom Sepez
dan, PTAL.
3 years, 11 months ago (2017-01-18 21:49:15 UTC) #4
dsinclair
lgtm
3 years, 11 months ago (2017-01-18 22:01:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613143002/20001
3 years, 11 months ago (2017-01-18 22:01:51 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 22:30:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/85c532b35b53836bebfdb8f8832905d5f313...

Powered by Google App Engine
This is Rietveld 408576698