Updating "Save passwords" screen for MultiWindow

Updating "Settings -> Save passwords" screen for MultiWindow

BUG=678815
https://bugs.chromium.org/p/chromium/issues/attachment?aid=265773&inline=1 show screen after changes (on top changed version, on bottom original)

Review-Url: https://codereview.chromium.org/2613133002
Cr-Commit-Position: refs/heads/master@{#442410}
Committed: https://chromium.googlesource.com/chromium/src/+/3b94a508d33ecf9687bd6d539dd940bfd89c59e9

[marcin, 2017-01-05 23:41:51]

Description was changed from

==========
Updating "Save passwords" screen for MultiWindow


Fixing "Saved passwords will appear here" text for MultiWindow

BUG=
==========

to

==========
Updating "Settings -> Save passwords" screen for MultiWindow

BUG=678815
==========

[marcin, 2017-01-05 23:46:04]

Description was changed from

==========
Updating "Settings -> Save passwords" screen for MultiWindow

BUG=678815
==========

to

==========
Updating "Settings -> Save passwords" screen for MultiWindow

BUG=678815

https://bugs.chromium.org/p/chromium/issues/attachment?aid=265773&inline=1 show
screen after changes (on top changed version, on bottom original)
==========

[marcin, 2017-01-05 23:47:18]

marcin@mwiacek.com changed reviewers:
+ finnur@chromium.org

[marcin, 2017-01-06 23:36:29]

marcin@mwiacek.com changed reviewers:
+ melandory@chromium.org

[Finnur, 2017-01-09 11:50:43]

LGTM, with nits.

https://codereview.chromium.org/2613133002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java
(right):

https://codereview.chromium.org/2613133002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java:58:

nit: Why the empty line here?

https://codereview.chromium.org/2613133002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java:113:
.findPreference(preferenceCategoryKey);
nit: Isn't the indentation off here?

[marcin, 2017-01-09 19:32:38]

On 2017/01/09 11:50:43, Finnur wrote:
> LGTM, with nits.
> 
>
https://codereview.chromium.org/2613133002/diff/1/chrome/android/java/src/org...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java
> (right):
> 
>
https://codereview.chromium.org/2613133002/diff/1/chrome/android/java/src/org...
>
chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java:58:
> 
> nit: Why the empty line here?
> 
>
https://codereview.chromium.org/2613133002/diff/1/chrome/android/java/src/org...
>
chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java:113:
> .findPreference(preferenceCategoryKey);
> nit: Isn't the indentation off here?

Hi,

Thank you, I have uploaded 2nd version - I removed empty line +
changed indentation (originally line had more than 80 chars).
Is it fine now ? If not, could you suggest, how should I format
.findPreference line ?

[marcin, 2017-01-09 19:40:43]

On 2017/01/09 19:32:38, marcin wrote:
> On 2017/01/09 11:50:43, Finnur wrote:
> > LGTM, with nits.
> > 
> >
>
https://codereview.chromium.org/2613133002/diff/1/chrome/android/java/src/org...
> > File
> >
>
chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java
> > (right):
> > 
> >
>
https://codereview.chromium.org/2613133002/diff/1/chrome/android/java/src/org...
> >
>
chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java:58:
> > 
> > nit: Why the empty line here?
> > 
> >
>
https://codereview.chromium.org/2613133002/diff/1/chrome/android/java/src/org...
> >
>
chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java:113:
> > .findPreference(preferenceCategoryKey);
> > nit: Isn't the indentation off here?
> 
> Hi,
> 
> Thank you, I have uploaded 2nd version - I removed empty line +
> changed indentation (originally line had more than 80 chars).
> Is it fine now ? If not, could you suggest, how should I format
> .findPreference line ?

OK, I have uploaded 3rd version. FindPreference line is formatted like
in original code. If there are no more comments, I will submit it.

[marcin, 2017-01-09 23:01:13]

The CQ bit was checked by marcin@mwiacek.com

[marcin, 2017-01-09 23:01:14]

The patchset sent to the CQ was uploaded after l-g-t-m from finnur@chromium.org
Link to the patchset: https://codereview.chromium.org/2613133002/#ps40001
(title: "Updating "SavePasswords" screen for MultiWindow")

[marcin, 2017-01-09 23:02:06]

The CQ bit was unchecked by marcin@mwiacek.com

[marcin, 2017-01-09 23:02:07]

The CQ bit was checked by marcin@mwiacek.com

[commit-bot: I haz the power, 2017-01-09 23:02:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 00:10:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484002927218910,
"parent_rev": "e97a4d2564c7ff2c4419164a119ec3d2424f7420", "commit_rev":
"3b94a508d33ecf9687bd6d539dd940bfd89c59e9"}

[commit-bot: I haz the power, 2017-01-10 00:10:32]

Description was changed from

==========
Updating "Settings -> Save passwords" screen for MultiWindow

BUG=678815

https://bugs.chromium.org/p/chromium/issues/attachment?aid=265773&inline=1 show
screen after changes (on top changed version, on bottom original)
==========

to

==========
Updating "Settings -> Save passwords" screen for MultiWindow

BUG=678815

https://bugs.chromium.org/p/chromium/issues/attachment?aid=265773&inline=1 show
screen after changes (on top changed version, on bottom original)

Review-Url: https://codereview.chromium.org/2613133002
Cr-Commit-Position: refs/heads/master@{#442410}
Committed:
https://chromium.googlesource.com/chromium/src/+/3b94a508d33ecf9687bd6d539dd9...
==========

[commit-bot: I haz the power, 2017-01-10 00:10:44]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3b94a508d33ecf9687bd6d539dd9...