Added 8 new vr layout tests for various requestPresent conditions

Added 8 new vr layout tests for various requestPresent conditions

Review-Url: https://codereview.chromium.org/2613103002
Cr-Commit-Position: refs/heads/master@{#441759}
Committed: https://chromium.googlesource.com/chromium/src/+/2a0f3cffd4af7c73fb9b10be44650c01428908e3

[bajones, 2017-01-05 19:31:46]

bajones@chromium.org changed reviewers:
+ bsheedy@chromium.org, leilei@chromium.org

[bajones, 2017-01-05 19:31:47]

A few new tests to stress the conformance of requestPresent a bit more. PTAL!

[bsheedy, 2017-01-05 19:43:54]

LGTM - luckily, only one seems to overlap with the tests I'm working on
(requestPresent_resolve_repeatwithoutgesture.html).

FYI, I've made a change to vr_test so that it creates an async_test and passes
it to the test function instead of trying to use promise_test. It makes the
tests a bit more verbose (have to wrap asserts with step()), but it's harder to
mess up. With the promise_test approach, I found that it was pretty easy to mess
up the return value so that the test ends early (without any real indication in
its output) instead of waiting for all the code to complete, particularly when
using multiple promises or runWithUserGesture(). This way, the test only ends
when specifically told to, so you can be sure the test finishes.

If that change goes through (feel free to object if you feel like the
promise_test solution is better after all), these will have to be updated to
work.

[bajones, 2017-01-05 19:55:06]

The CQ bit was checked by bajones@chromium.org

[commit-bot: I haz the power, 2017-01-05 19:55:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bajones, 2017-01-05 19:56:47]

On 2017/01/05 19:43:54, bsheedy wrote:
> LGTM - luckily, only one seems to overlap with the tests I'm working on
> (requestPresent_resolve_repeatwithoutgesture.html).

Thanks! And sorry for the accidental overlap. I was going to send a list of
cases I felt could easily be tested, but it turned out to be just as easy to
simply write the test. :) Kudos for that!

> FYI, I've made a change to vr_test so that it creates an async_test and passes
> it to the test function instead of trying to use promise_test. It makes the
> tests a bit more verbose (have to wrap asserts with step()), but it's harder
to
> mess up. With the promise_test approach, I found that it was pretty easy to
mess
> up the return value so that the test ends early (without any real indication
in
> its output) instead of waiting for all the code to complete, particularly when
> using multiple promises or runWithUserGesture(). This way, the test only ends
> when specifically told to, so you can be sure the test finishes.
> 
> If that change goes through (feel free to object if you feel like the
> promise_test solution is better after all), these will have to be updated to
> work.

No objection here. That definitely sounds like a nice simplification.

[Lei Lei, 2017-01-05 20:15:50]

lgtm

[commit-bot: I haz the power, 2017-01-05 21:30:15]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483646106674950, "parent_rev":
"c57d9c242d1be6076c12838c4fc91a081b887c01", "commit_rev":
"2a0f3cffd4af7c73fb9b10be44650c01428908e3"}

[commit-bot: I haz the power, 2017-01-05 21:30:43]

Description was changed from

==========
Added 8 new vr layout tests for various requestPresent conditions
==========

to

==========
Added 8 new vr layout tests for various requestPresent conditions

Review-Url: https://codereview.chromium.org/2613103002
Cr-Commit-Position: refs/heads/master@{#441759}
Committed:
https://chromium.googlesource.com/chromium/src/+/2a0f3cffd4af7c73fb9b10be4465...
==========

[commit-bot: I haz the power, 2017-01-05 21:30:43]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2a0f3cffd4af7c73fb9b10be4465...