Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2613093003: Landing again: "Make FTP directory parser less strict" (Closed)

Created:
3 years, 11 months ago by Jinsuk Kim
Modified:
3 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Paweł Hajdan Jr.
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Landing again: "Make FTP directory parser less strict" The new testfiles added in the CL had a problem. Fixed it now. This reverts commit 9c484365968491ca416461d7c982aca155ff26bf. BUG=676762 R=mmenke@chromium.org Review-Url: https://codereview.chromium.org/2613093003 . Cr-Commit-Position: refs/heads/master@{#442064} Committed: https://chromium.googlesource.com/chromium/src/+/9276998c3811db276e04aff731b8aebfdae8ce71

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
A net/data/ftp/dir-listing-ls-34 View 1 chunk +2 lines, -0 lines 0 comments Download
A net/data/ftp/dir-listing-ls-34.expected View 1 chunk +17 lines, -0 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jinsuk Kim
The test file got mangled when I got the patch downloaded from Rietveld (git patch) ...
3 years, 11 months ago (2017-01-06 07:51:04 UTC) #2
mmenke
On 2017/01/06 07:51:04, Jinsuk Kim wrote: > The test file got mangled when I got ...
3 years, 11 months ago (2017-01-06 11:29:01 UTC) #3
mmenke
On 2017/01/06 11:29:01, mmenke wrote: > On 2017/01/06 07:51:04, Jinsuk Kim wrote: > > The ...
3 years, 11 months ago (2017-01-06 11:29:31 UTC) #4
Jinsuk Kim
On 2017/01/06 11:29:31, mmenke wrote: > On 2017/01/06 11:29:01, mmenke wrote: > > On 2017/01/06 ...
3 years, 11 months ago (2017-01-06 21:24:49 UTC) #5
Jinsuk Kim
3 years, 11 months ago (2017-01-06 21:49:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9276998c3811db276e04aff731b8aebfdae8ce71 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698