Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2613063002: Remove obsolete class DownstreamChromiumBrowserProvider. (Closed)

Created:
3 years, 11 months ago by sdefresne
Modified:
3 years, 11 months ago
CC:
chromium-reviews, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete class DownstreamChromiumBrowserProvider. This class is no longer used nor the factory function, so remove them both and cleanup BUILD.gn files. Remove obsolete public_deps that were there for the upstreaming process and are no longer required. BUG=676278 Review-Url: https://codereview.chromium.org/2613063002 Cr-Commit-Position: refs/heads/master@{#442249} Committed: https://chromium.googlesource.com/chromium/src/+/a87330e6389b26bdfe5623b677f79be4bccb7f92

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -92 lines) Patch
M ios/chrome/browser/BUILD.gn View 1 chunk +0 lines, -34 lines 0 comments Download
D ios/chrome/browser/downstream_chromium_browser_provider.h View 1 chunk +0 lines, -22 lines 0 comments Download
D ios/chrome/browser/downstream_chromium_browser_provider.mm View 1 chunk +0 lines, -9 lines 0 comments Download
D ios/chrome/browser/downstream_chromium_browser_provider_factory.mm View 1 chunk +0 lines, -13 lines 0 comments Download
M ios/public/provider/chrome/browser/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
M ios/public/provider/chrome/browser/build_config.gni View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (19 generated)
sdefresne
3 years, 11 months ago (2017-01-05 16:23:25 UTC) #3
rohitrao (ping after 24h)
lgtm
3 years, 11 months ago (2017-01-05 16:29:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613063002/60001
3 years, 11 months ago (2017-01-09 14:55:16 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 14:59:47 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a87330e6389b26bdfe5623b677f7...

Powered by Google App Engine
This is Rietveld 408576698