Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 2613033002: Disable automatic handling of SEH exceptions in gtest (Closed)

Created:
3 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 11 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable automatic handling of SEH exceptions in gtest This turns hangs on win_dbg into actually crashes R=machenbach@chromium.org BUG= Review-Url: https://codereview.chromium.org/2613033002 Cr-Commit-Position: refs/heads/master@{#42090} Committed: https://chromium.googlesource.com/v8/v8/+/e2d2dd5318b7bed8724e02ff46133854c6873987

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M test/unittests/run-all-unittests.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
jochen (gone - plz use gerrit)
3 years, 11 months ago (2017-01-05 11:58:37 UTC) #1
Michael Achenbach
lgtm
3 years, 11 months ago (2017-01-05 11:59:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2613033002/1
3 years, 11 months ago (2017-01-05 12:00:34 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 12:22:32 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/e2d2dd5318b7bed8724e02ff46133854c68...

Powered by Google App Engine
This is Rietveld 408576698