Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2612953003: Remove the declaration of WindowProxy::updateDocumentWrapper (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the declaration of WindowProxy::updateDocumentWrapper The method is not defined. BUG=677253 Review-Url: https://codereview.chromium.org/2612953003 Cr-Commit-Position: refs/heads/master@{#441646} Committed: https://chromium.googlesource.com/chromium/src/+/cbb1ee21e72f53c373d4a3468bfc8a6dfc10f514

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
haraken
PTAL
3 years, 11 months ago (2017-01-05 11:27:03 UTC) #2
Yuki
lgtm
3 years, 11 months ago (2017-01-05 12:11:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612953003/1
3 years, 11 months ago (2017-01-05 12:11:22 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 14:04:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cbb1ee21e72f53c373d4a3468bfc...

Powered by Google App Engine
This is Rietveld 408576698