Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2612943002:
Mark fast/text/emphasis.html as flaky on all platforms (Closed)
DescriptionMark fast/text/emphasis.html as flaky on all platforms
R=qyearsley@chromium.org,kbr@chromium.org
BUG=663858, 678454
Committed: https://crrev.com/d7473c2efc545bdb80ffd2c5d737baf5ea301318
Cr-Commit-Position: refs/heads/master@{#441561}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Mark storage/indexeddb/objectstore-cursor.html as flaky #Patch Set 3 : Delete comments, alphabetize #Patch Set 4 : New patch that just re-marks fast/text/emphasis as flaky on all platforms #Messages
Total messages: 18 (11 generated)
Description was changed from ========== Mark fast/text/emphasis.html and fast/text/ellipsis-stroked.html as flaky R=qyearsley@chromium.org BUG=663858 ========== to ========== Mark fast/text/emphasis.html and fast/text/ellipsis-stroked.html as flaky R=qyearsley@chromium.org,kbr@chromium.org BUG=663858,678454 ==========
https://codereview.chromium.org/2612943002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/2612943002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/TestExpectations:1722: # Replaced with 663858 below Nit: Could add a period. https://codereview.chromium.org/2612943002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/TestExpectations:1723: # crbug.com/611658 [ Win7 ] fast/text/emphasis.html [ Failure ] Would it be incorrect to leave this line un-commented? (Does lint complain?) https://codereview.chromium.org/2612943002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/TestExpectations:2264: # Possible duplicate of crbug.com/498021 I'm not sure whether this comment is helpful now (feel free to leave it in here if you're not sure either) https://codereview.chromium.org/2612943002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/TestExpectations:2265: crbug.com/663855 fast/text/ellipsis-stroked.html [ Pass Failure ] Should this be crbug.com/663858 as well?
Description was changed from ========== Mark fast/text/emphasis.html and fast/text/ellipsis-stroked.html as flaky R=qyearsley@chromium.org,kbr@chromium.org BUG=663858,678454 ========== to ========== Mark fast/text/{emphasis,ellipsis-stroked}.html, storage/indexeddb/objectstore-cursor.html as flaky R=qyearsley@chromium.org,kbr@chromium.org BUG=663858,678454 ==========
lgtm
The CQ bit was checked by jeffcarp@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from qyearsley@chromium.org Link to the patchset: https://codereview.chromium.org/2612943002/#ps40001 (title: "Delete comments, alphabetize")
The CQ bit was unchecked by jeffcarp@chromium.org
Description was changed from
==========
Mark fast/text/{emphasis,ellipsis-stroked}.html,
storage/indexeddb/objectstore-cursor.html as flaky
R=qyearsley@chromium.org,kbr@chromium.org
BUG=663858,678454
==========
to
==========
Mark fast/text/emphasis.html as flaky on all platforms
R=qyearsley@chromium.org,kbr@chromium.org
BUG=663858,678454
==========
The CQ bit was checked by jeffcarp@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from qyearsley@chromium.org Link to the patchset: https://codereview.chromium.org/2612943002/#ps50001 (title: "New patch that just re-marks fast/text/emphasis as flaky on all platforms")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Still lgtm
CQ is committing da patch.
Bot data: {"patchset_id": 50001, "attempt_start_ts": 1483579934743230,
"parent_rev": "727197fbe5c591b057eede7bcc8f87d2c7bf8a42", "commit_rev":
"9277f0bbd40bcd0a9b1b6285f339fd3f7f158376"}
Message was sent while issue was closed.
Description was changed from ========== Mark fast/text/emphasis.html as flaky on all platforms R=qyearsley@chromium.org,kbr@chromium.org BUG=663858,678454 ========== to ========== Mark fast/text/emphasis.html as flaky on all platforms R=qyearsley@chromium.org,kbr@chromium.org BUG=663858,678454 Review-Url: https://codereview.chromium.org/2612943002 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:50001)
Message was sent while issue was closed.
Description was changed from ========== Mark fast/text/emphasis.html as flaky on all platforms R=qyearsley@chromium.org,kbr@chromium.org BUG=663858,678454 Review-Url: https://codereview.chromium.org/2612943002 ========== to ========== Mark fast/text/emphasis.html as flaky on all platforms R=qyearsley@chromium.org,kbr@chromium.org BUG=663858,678454 Committed: https://crrev.com/d7473c2efc545bdb80ffd2c5d737baf5ea301318 Cr-Commit-Position: refs/heads/master@{#441561} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/d7473c2efc545bdb80ffd2c5d737baf5ea301318 Cr-Commit-Position: refs/heads/master@{#441561} |
