Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2612903002: [ignition] Avoid unnecessary ToName calls in VisitClassLiteralProperties (Closed)

Created:
3 years, 11 months ago by adamk
Modified:
3 years, 11 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ignition] Avoid unnecessary ToName calls in VisitClassLiteralProperties R=rmcilroy@chromium.org BUG=v8:5799 Review-Url: https://codereview.chromium.org/2612903002 Cr-Commit-Position: refs/heads/master@{#42098} Committed: https://chromium.googlesource.com/v8/v8/+/3166d4293e88cbe26ba3ffc39f519705255985ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M src/interpreter/bytecode-generator.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ClassDeclarations.golden View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
adamk
3 years, 11 months ago (2017-01-04 22:48:42 UTC) #1
rmcilroy
lgtm
3 years, 11 months ago (2017-01-05 10:58:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612903002/1
3 years, 11 months ago (2017-01-05 18:00:36 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 18:25:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/3166d4293e88cbe26ba3ffc39f519705255...

Powered by Google App Engine
This is Rietveld 408576698