Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 2612893003: Use correct element for Form Not Secure warning (Closed)

Created:
3 years, 11 months ago by elawrence
Modified:
3 years, 11 months ago
Reviewers:
Mathieu
CC:
dvadym, chromium-reviews, mlamouri+watch-content_chromium.org, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, jam, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use correct element for Form Not Secure warning Web forms may not contain a username element, therefore it is not safe to assume that such an element exists when calling ShowNotSecureWarning. Instead, use the actual element found by the autofill logic. BUG=678769 Review-Url: https://codereview.chromium.org/2612893003 Cr-Commit-Position: refs/heads/master@{#441988} Committed: https://chromium.googlesource.com/chromium/src/+/35a8434eac8dba744785df28082e2d85259e7978

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M components/autofill/content/renderer/form_autofill_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
elawrence
PTAL? This is a tiny fix to a corner case for Form-Not-Secure UI; that feature ...
3 years, 11 months ago (2017-01-06 16:15:36 UTC) #6
Mathieu
lgtm
3 years, 11 months ago (2017-01-06 18:01:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612893003/1
3 years, 11 months ago (2017-01-06 18:33:54 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 18:39:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/35a8434eac8dba744785df28082e...

Powered by Google App Engine
This is Rietveld 408576698