Rename cc property tree node owner_id to owning_layer_id.

Rename cc property tree node owner_id to owning_layer_id.

Also added brief documentation on the primary node id fields. While it's
slightly redundant IMO it's still helpful for new folks reading the code
given how many different types of ids are in the code base.

BUG=674258
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/a4c2d8689df6df3e4645b24beb4d69a41f644e9a
Cr-Commit-Position: refs/heads/master@{#441541}

[wkorman, 2017-01-04 21:48:09]

Description was changed from

==========
Rename cc property tree node owner_id to owning_layer_id.

Also added brief documentation on the primary node id fields. While it's
slightly redundant IMO it's still helpful for new folks reading the code
given how many different types of ids are in the code base.

BUG=674258
==========

to

==========
Rename cc property tree node owner_id to owning_layer_id.

Also added brief documentation on the primary node id fields. While it's
slightly redundant IMO it's still helpful for new folks reading the code
given how many different types of ids are in the code base.

BUG=674258
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[wkorman, 2017-01-04 21:48:09]

Description was changed from

==========
Rename cc property tree node owner_id to owning_layer_id.

Also added brief documentation on the primary node id fields. While it's
slightly redundant IMO it's still helpful for new folks reading the code
given how many different types of ids are in the code base.

BUG=674258
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Rename cc property tree node owner_id to owning_layer_id.

Also added brief documentation on the primary node id fields. While it's
slightly redundant IMO it's still helpful for new folks reading the code
given how many different types of ids are in the code base.

BUG=674258
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[wkorman, 2017-01-04 21:51:33]

wkorman@chromium.org changed reviewers:
+ ajuma@chromium.org, chrishtr@chromium.org

[wkorman, 2017-01-04 21:51:34]

It sounds crazy but I spent a long time thinking owner_id was another node
reference for some purpose. There is no qualifier on the field name anywhere and
the only comment explaining that it's actually the layer id is in scroll_node.h.

This seems at least a reasonable low impact improvement for now, open to
thoughts of course.

[chrishtr, 2017-01-04 22:22:25]

lgtm

[ajuma, 2017-01-04 22:25:27]

On 2017/01/04 21:51:34, wkorman wrote:
> It sounds crazy but I spent a long time thinking owner_id was another node
> reference for some purpose. There is no qualifier on the field name anywhere
and
> the only comment explaining that it's actually the layer id is in
scroll_node.h.
> 
> This seems at least a reasonable low impact improvement for now, open to
> thoughts of course.

lgtm, this is certainly an improvement. Thanks for the added documentation too!

[wkorman, 2017-01-04 22:27:56]

The CQ bit was checked by wkorman@chromium.org

[commit-bot: I haz the power, 2017-01-04 22:28:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 01:16:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483568876586360, "parent_rev":
"75ed9a34944a2e18ffd5c2d588c240b6767c304d", "commit_rev":
"0bf2afb74ae476b377cc952bea717e0c5970f6b2"}

[commit-bot: I haz the power, 2017-01-05 01:17:58]

Description was changed from

==========
Rename cc property tree node owner_id to owning_layer_id.

Also added brief documentation on the primary node id fields. While it's
slightly redundant IMO it's still helpful for new folks reading the code
given how many different types of ids are in the code base.

BUG=674258
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Rename cc property tree node owner_id to owning_layer_id.

Also added brief documentation on the primary node id fields. While it's
slightly redundant IMO it's still helpful for new folks reading the code
given how many different types of ids are in the code base.

BUG=674258
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2612883002
==========

[commit-bot: I haz the power, 2017-01-05 01:18:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-05 01:20:15]

Description was changed from

==========
Rename cc property tree node owner_id to owning_layer_id.

Also added brief documentation on the primary node id fields. While it's
slightly redundant IMO it's still helpful for new folks reading the code
given how many different types of ids are in the code base.

BUG=674258
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2612883002
==========

to

==========
Rename cc property tree node owner_id to owning_layer_id.

Also added brief documentation on the primary node id fields. While it's
slightly redundant IMO it's still helpful for new folks reading the code
given how many different types of ids are in the code base.

BUG=674258
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/a4c2d8689df6df3e4645b24beb4d69a41f644e9a
Cr-Commit-Position: refs/heads/master@{#441541}
==========

[commit-bot: I haz the power, 2017-01-05 01:20:16]

Patchset 1 (id:??) landed as
https://crrev.com/a4c2d8689df6df3e4645b24beb4d69a41f644e9a
Cr-Commit-Position: refs/heads/master@{#441541}