Fix bug removing temporary surface references.

Fix bug removing temporary surface references.

If there are multiple surfaces from the same FrameSinkId that have
temporary references we might not remove one of the temporary
references.  We track the temporary references in DisplayConfigurator
and remove them when a real reference is added. An iterator is
incremented twice in some cases and we stop tracking one extra temporary
reference we never removed. DisplayCompositor no longer knows about the
temporary reference, so it never gets removed.

BUG=none

Review-Url: https://codereview.chromium.org/2612873003
Cr-Commit-Position: refs/heads/master@{#441761}
Committed: https://chromium.googlesource.com/chromium/src/+/eec5f76832b767aea7ef2990cf738df292c0f8fc

[kylechar, 2017-01-05 18:01:40]

kylechar@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2017-01-05 19:46:31]

lgtm

[kylechar, 2017-01-05 20:12:15]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2017-01-05 20:12:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 21:33:53]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483647135956230, "parent_rev":
"c6686c5bc30f863b9ec341f761708c767ab1673c", "commit_rev":
"eec5f76832b767aea7ef2990cf738df292c0f8fc"}

[commit-bot: I haz the power, 2017-01-05 21:34:21]

Description was changed from

==========
Fix bug removing temporary surface references.

If there are multiple surfaces from the same FrameSinkId that have
temporary references we might not remove one of the temporary
references.  We track the temporary references in DisplayConfigurator
and remove them when a real reference is added. An iterator is
incremented twice in some cases and we stop tracking one extra temporary
reference we never removed. DisplayCompositor no longer knows about the
temporary reference, so it never gets removed.

BUG=none
==========

to

==========
Fix bug removing temporary surface references.

If there are multiple surfaces from the same FrameSinkId that have
temporary references we might not remove one of the temporary
references.  We track the temporary references in DisplayConfigurator
and remove them when a real reference is added. An iterator is
incremented twice in some cases and we stop tracking one extra temporary
reference we never removed. DisplayCompositor no longer knows about the
temporary reference, so it never gets removed.

BUG=none

Review-Url: https://codereview.chromium.org/2612873003
Cr-Commit-Position: refs/heads/master@{#441761}
Committed:
https://chromium.googlesource.com/chromium/src/+/eec5f76832b767aea7ef2990cf73...
==========

[commit-bot: I haz the power, 2017-01-05 21:34:22]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eec5f76832b767aea7ef2990cf73...