Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2612863002: Make skia::GetNativeDrawingContext Windows-only (Closed)

Created:
3 years, 11 months ago by f(malita)
Modified:
3 years, 11 months ago
Reviewers:
reed1
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make skia::GetNativeDrawingContext Windows-only No longer used on other platforms. BUG=675977 R=reed@google.com Review-Url: https://codereview.chromium.org/2612863002 Cr-Commit-Position: refs/heads/master@{#441647} Committed: https://chromium.googlesource.com/chromium/src/+/98d3363db8506c383289ed1bbcd00c4169614bbe

Patch Set 1 #

Patch Set 2 : return an HDC #

Patch Set 3 : guard unit test for Win only #

Patch Set 4 : more guarding #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -126 lines) Patch
M skia/BUILD.gn View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
D skia/ext/bitmap_platform_device_mac_unittest.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M skia/ext/bitmap_platform_device_win.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
M skia/ext/platform_canvas.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M skia/ext/platform_canvas.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M skia/ext/platform_canvas_unittest.cc View 1 2 3 5 chunks +5 lines, -41 lines 0 comments Download

Messages

Total messages: 19 (15 generated)
f(malita)
3 years, 11 months ago (2017-01-04 20:09:04 UTC) #3
reed1
lgtm
3 years, 11 months ago (2017-01-04 21:31:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612863002/60001
3 years, 11 months ago (2017-01-05 14:08:35 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 14:12:37 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/98d3363db8506c383289ed1bbcd0...

Powered by Google App Engine
This is Rietveld 408576698