Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Issue 2612853002: Revert of Use TaskScheduler instead of WorkerPool in gbm_surfaceless.cc. (Closed)

Created:
3 years, 11 months ago by afakhry
Modified:
3 years, 11 months ago
Reviewers:
dnicoara, fdoray
CC:
chromium-reviews, kalyank, piman+watch_chromium.org, ozone-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use TaskScheduler instead of WorkerPool in gbm_surfaceless.cc. (patchset #2 id:20001 of https://codereview.chromium.org/2609733002/ ) Reason for revert: Causes the UI to crash on peach_pit and multiple HWTest failures on the PFQ and the informational builder. See BUG=678296 . Original issue's description: > Use TaskScheduler instead of WorkerPool in gbm_surfaceless.cc. > > The following traits are used: > > Priority: Inherited (default) > The priority is inherited from the calling context (i.e. TaskTraits > are initialized with the priority of the current task). > > Shutdown behavior: CONTINUE_ON_SHUTDOWN > Tasks posted with this mode which have not started executing before > shutdown is initiated will never run. Tasks with this mode running at > shutdown will be ignored (the worker will not be joined). > > Note: Tasks that were previously posted to base::WorkerPool should > use this shutdown behavior because this is how base::WorkerPool > handles all its tasks. > > May Block: > Tasks posted with MayBlock() may block. This includes but is not > limited to tasks that wait on synchronous file I/O operations: > read or write a file from disk, interact with a pipe or a socket, > rename or delete a file, enumerate files in a directory, etc. This > trait isn't required for the mere use of locks. > > BUG=659191 > > Committed: https://crrev.com/0127fd25bd985f1f5f87c0a7c060d3159142086a > Cr-Commit-Position: refs/heads/master@{#441139} TBR=dnicoara@chromium.org,fdoray@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=659191 Committed: https://crrev.com/2b42f8092f30184dda0b785d26fdf7538c394220 Cr-Commit-Position: refs/heads/master@{#441438}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M ui/ozone/platform/drm/gpu/gbm_surfaceless.cc View 2 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
afakhry
Created Revert of Use TaskScheduler instead of WorkerPool in gbm_surfaceless.cc.
3 years, 11 months ago (2017-01-04 19:23:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612853002/1
3 years, 11 months ago (2017-01-04 19:23:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 20:01:18 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 20:03:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b42f8092f30184dda0b785d26fdf7538c394220
Cr-Commit-Position: refs/heads/master@{#441438}

Powered by Google App Engine
This is Rietveld 408576698