Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 2612793006: Remove unused Textfield::SetShadows. (Closed)

Created:
3 years, 11 months ago by Evan Stade
Modified:
3 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, James Su, shuchen+watch_chromium.org, yusukes+watch_chromium.org, nona+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused Textfield::SetShadows. BUG=624175 Review-Url: https://codereview.chromium.org/2612793006 Cr-Commit-Position: refs/heads/master@{#441706} Committed: https://chromium.googlesource.com/chromium/src/+/21dd7bac85ae75e2887c61696f4485c4e5c3739d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M ui/views/controls/textfield/textfield.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Evan Stade
3 years, 11 months ago (2017-01-05 17:51:18 UTC) #4
sky
LGTM
3 years, 11 months ago (2017-01-05 18:01:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612793006/1
3 years, 11 months ago (2017-01-05 18:21:14 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 18:35:43 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/21dd7bac85ae75e2887c61696f44...

Powered by Google App Engine
This is Rietveld 408576698