Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2612773007: Remove CFX_MapPtrToPtr and templates. (Closed)

Created:
3 years, 11 months ago by Tom Sepez
Modified:
3 years, 11 months ago
Reviewers:
Lei Zhang, dsinclair, Wei Li, npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove CFX_MapPtrToPtr and templates. All usage is now replaced with stl equivalents. Move one definition from fx_basic.h to where it's actually needed. Review-Url: https://codereview.chromium.org/2612773007 Committed: https://pdfium.googlesource.com/pdfium/+/591ed144f8dfe4b2915f01f1cc725f584d498a3f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -308 lines) Patch
M BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M core/fxcrt/fx_basic.h View 1 chunk +0 lines, -102 lines 0 comments Download
D core/fxcrt/fx_basic_maps.cpp View 1 chunk +0 lines, -158 lines 0 comments Download
D core/fxcrt/fx_basic_plex.cpp View 1 chunk +0 lines, -26 lines 0 comments Download
D core/fxcrt/plex.h View 1 chunk +0 lines, -19 lines 0 comments Download
M xfa/fxfa/parser/xfa_object.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Tom Sepez
Dan, for review.
3 years, 11 months ago (2017-01-06 17:52:48 UTC) #4
Tom Sepez
On 2017/01/06 17:52:48, Tom Sepez wrote: > Dan, for review. +npm/weili as reviewers in Dan's ...
3 years, 11 months ago (2017-01-06 18:12:18 UTC) #10
npm
lgtm
3 years, 11 months ago (2017-01-06 18:26:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612773007/1
3 years, 11 months ago (2017-01-06 18:29:34 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 18:29:52 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/591ed144f8dfe4b2915f01f1cc725f584d49...

Powered by Google App Engine
This is Rietveld 408576698