Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2612763002: [turbofan] Add constant-folding for CheckedFloat64ToInt32. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add constant-folding for CheckedFloat64ToInt32. BUG=v8:5267 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2612763002 Cr-Commit-Position: refs/heads/master@{#42060} Committed: https://chromium.googlesource.com/v8/v8/+/7aa3931fa4d54091e4746e422be1d6f3ff89c816

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M src/compiler/simplified-operator-reducer.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-04 08:34:50 UTC) #1
Benedikt Meurer
Hey Jaro, Here's another easy one. Please take a look. Thanks, Benedikt
3 years, 11 months ago (2017-01-04 08:35:23 UTC) #4
Jarin
lgtm
3 years, 11 months ago (2017-01-04 08:49:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612763002/1
3 years, 11 months ago (2017-01-04 08:49:58 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 09:43:29 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7aa3931fa4d54091e4746e422be1d6f3ff8...

Powered by Google App Engine
This is Rietveld 408576698