Add more tests for compiler-dispatcher

Add more tests for compiler-dispatcher

BUG=v8:5215
R=marja@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2612753002
Cr-Commit-Position: refs/heads/master@{#42062}
Committed: https://chromium.googlesource.com/v8/v8/+/a8b16f44242e701cb9030b86835b58fa7593f4d6

[jochen (gone - plz use gerrit), 2017-01-04 08:22:33]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 08:22:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2017-01-04 08:23:23]

https://codereview.chromium.org/2612753002/diff/1/src/compiler-dispatcher/com...
File src/compiler-dispatcher/compiler-dispatcher.cc (left):

https://codereview.chromium.org/2612753002/diff/1/src/compiler-dispatcher/com...
src/compiler-dispatcher/compiler-dispatcher.cc:25: v8::TryCatch
try_catch(reinterpret_cast<v8::Isolate*>(isolate));
turns out that we only create a pending exception, but don't schedule it, so the
trycatch did nothing

[commit-bot: I haz the power, 2017-01-04 08:47:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 08:47:17]

Dry run: This issue passed the CQ dry run.

[marja, 2017-01-04 10:05:55]

lgtm

[jochen (gone - plz use gerrit), 2017-01-04 10:06:12]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2017-01-04 10:06:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 10:08:00]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483524372644720, "parent_rev":
"ffa4010cc861318e5aefd5952ecd7396e241f412", "commit_rev":
"a8b16f44242e701cb9030b86835b58fa7593f4d6"}

[commit-bot: I haz the power, 2017-01-04 10:08:05]

Description was changed from

==========
Add more tests for compiler-dispatcher

BUG=v8:5215
R=marja@chromium.org,vogelheim@chromium.org
==========

to

==========
Add more tests for compiler-dispatcher

BUG=v8:5215
R=marja@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2612753002
Cr-Commit-Position: refs/heads/master@{#42062}
Committed:
https://chromium.googlesource.com/v8/v8/+/a8b16f44242e701cb9030b86835b58fa759...
==========

[commit-bot: I haz the power, 2017-01-04 10:08:05]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a8b16f44242e701cb9030b86835b58fa759...

[vogelheim, 2017-01-04 10:08:49]

lgtm

https://codereview.chromium.org/2612753002/diff/1/src/compiler-dispatcher/com...
File src/compiler-dispatcher/compiler-dispatcher.cc (right):

https://codereview.chromium.org/2612753002/diff/1/src/compiler-dispatcher/com...
src/compiler-dispatcher/compiler-dispatcher.cc:62: }
nitpick: Hmm... How about:

DCHECK_EQ(job->status() == CompileJobStatus::kFailed,
          isolate->has_pending_exception());
if (ob->status() == CompileJobStatus::kFailed
    && exception_handling == ExceptionHandling::kSwallow)
  isolate->clear_pending_exception();

https://codereview.chromium.org/2612753002/diff/1/test/unittests/compiler-dis...
File test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc (right):

https://codereview.chromium.org/2612753002/diff/1/test/unittests/compiler-dis...
test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc:437:
CompilerDispatcher dispatcher(i_isolate(), &platform, 50);
For my understanding: The point is to over-run an artificially small stack?

[jochen (gone - plz use gerrit), 2017-01-04 10:23:18]

https://codereview.chromium.org/2612753002/diff/1/src/compiler-dispatcher/com...
File src/compiler-dispatcher/compiler-dispatcher.cc (right):

https://codereview.chromium.org/2612753002/diff/1/src/compiler-dispatcher/com...
src/compiler-dispatcher/compiler-dispatcher.cc:62: }
On 2017/01/04 at 10:08:49, vogelheim wrote:
> nitpick: Hmm... How about:
> 
> DCHECK_EQ(job->status() == CompileJobStatus::kFailed,
>           isolate->has_pending_exception());
> if (ob->status() == CompileJobStatus::kFailed
>     && exception_handling == ExceptionHandling::kSwallow)
>   isolate->clear_pending_exception();

will do in a follow-up

https://codereview.chromium.org/2612753002/diff/1/test/unittests/compiler-dis...
File test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc (right):

https://codereview.chromium.org/2612753002/diff/1/test/unittests/compiler-dis...
test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc:437:
CompilerDispatcher dispatcher(i_isolate(), &platform, 50);
On 2017/01/04 at 10:08:49, vogelheim wrote:
> For my understanding: The point is to over-run an artificially small stack?

yes

we can't put a real syntax error here, because RunJS() wouldn't work then