Don't check implicit flag for serializing background and -webkit-mask

Don't check implicit flag for serializing background and -webkit-mask

This patch edits the StylePropertySerializer to no longer look at the
implicit flag, in particular for the remaining two properties using it,
background and -webkit-mask. This makes those shorthands behave more
consistently. In both of the updated test cases, the set values would
result in an identical set of longhands as being set by the new returned
shorthand, aside from the (invisible) implicit flag. We now allow this
serialization to remove the case where styles can appear identical in
their longhands (shorthands technically are not in the styles) but still
serialize differently.

This patch removes the last usage of the implicit flag outside of
devtools. We may simply want to remove the usage there as the flag is
not actually set particularly consistently, and does not even make sense
for properties like background and animation.

BUG=471917
Committed: https://crrev.com/dc0de0608505a5bf92e0ee71f2efd4a7424f2969
Cr-Commit-Position: refs/heads/master@{#441331}

[Timothy Loh, 2017-01-04 06:07:02]

The CQ bit was checked by timloh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 06:07:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Timothy Loh, 2017-01-04 06:17:57]

timloh@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2017-01-04 06:44:22]

lgtm

[Timothy Loh, 2017-01-04 06:47:05]

The CQ bit was unchecked by timloh@chromium.org

[Timothy Loh, 2017-01-04 06:47:11]

The CQ bit was checked by timloh@chromium.org

[commit-bot: I haz the power, 2017-01-04 06:47:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 07:38:47]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483512431696690, "parent_rev":
"a6488cfa5d193fcd59ee8d2c7848025a76f648b9", "commit_rev":
"3ba33c87bbd328fe1f2414ac8f6600348fb8efbb"}

[commit-bot: I haz the power, 2017-01-04 07:39:13]

Description was changed from

==========
Don't check implicit flag for serializing background and -webkit-mask

This patch edits the StylePropertySerializer to no longer look at the
implicit flag, in particular for the remaining two properties using it,
background and -webkit-mask. This makes those shorthands behave more
consistently. In both of the updated test cases, the set values would
result in an identical set of longhands as being set by the new returned
shorthand, aside from the (invisible) implicit flag. We now allow this
serialization to remove the case where styles can appear identical in
their longhands (shorthands technically are not in the styles) but still
serialize differently.

This patch removes the last usage of the implicit flag outside of
devtools. We may simply want to remove the usage there as the flag is
not actually set particularly consistently, and does not even make sense
for properties like background and animation.

BUG=471917
==========

to

==========
Don't check implicit flag for serializing background and -webkit-mask

This patch edits the StylePropertySerializer to no longer look at the
implicit flag, in particular for the remaining two properties using it,
background and -webkit-mask. This makes those shorthands behave more
consistently. In both of the updated test cases, the set values would
result in an identical set of longhands as being set by the new returned
shorthand, aside from the (invisible) implicit flag. We now allow this
serialization to remove the case where styles can appear identical in
their longhands (shorthands technically are not in the styles) but still
serialize differently.

This patch removes the last usage of the implicit flag outside of
devtools. We may simply want to remove the usage there as the flag is
not actually set particularly consistently, and does not even make sense
for properties like background and animation.

BUG=471917

Review-Url: https://codereview.chromium.org/2612733002
==========

[commit-bot: I haz the power, 2017-01-04 07:39:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-04 07:42:05]

Description was changed from

==========
Don't check implicit flag for serializing background and -webkit-mask

This patch edits the StylePropertySerializer to no longer look at the
implicit flag, in particular for the remaining two properties using it,
background and -webkit-mask. This makes those shorthands behave more
consistently. In both of the updated test cases, the set values would
result in an identical set of longhands as being set by the new returned
shorthand, aside from the (invisible) implicit flag. We now allow this
serialization to remove the case where styles can appear identical in
their longhands (shorthands technically are not in the styles) but still
serialize differently.

This patch removes the last usage of the implicit flag outside of
devtools. We may simply want to remove the usage there as the flag is
not actually set particularly consistently, and does not even make sense
for properties like background and animation.

BUG=471917

Review-Url: https://codereview.chromium.org/2612733002
==========

to

==========
Don't check implicit flag for serializing background and -webkit-mask

This patch edits the StylePropertySerializer to no longer look at the
implicit flag, in particular for the remaining two properties using it,
background and -webkit-mask. This makes those shorthands behave more
consistently. In both of the updated test cases, the set values would
result in an identical set of longhands as being set by the new returned
shorthand, aside from the (invisible) implicit flag. We now allow this
serialization to remove the case where styles can appear identical in
their longhands (shorthands technically are not in the styles) but still
serialize differently.

This patch removes the last usage of the implicit flag outside of
devtools. We may simply want to remove the usage there as the flag is
not actually set particularly consistently, and does not even make sense
for properties like background and animation.

BUG=471917

Committed: https://crrev.com/dc0de0608505a5bf92e0ee71f2efd4a7424f2969
Cr-Commit-Position: refs/heads/master@{#441331}
==========

[commit-bot: I haz the power, 2017-01-04 07:42:06]

Patchset 1 (id:??) landed as
https://crrev.com/dc0de0608505a5bf92e0ee71f2efd4a7424f2969
Cr-Commit-Position: refs/heads/master@{#441331}