Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 2612693002: X87: [ic] Use StrictEqual/Equal builtins for CompareIC slow path. (Closed)

Created:
3 years, 11 months ago by zhengxing.li
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [ic] Use StrictEqual/Equal builtins for CompareIC slow path. port d3ed71ed87426046afe8938592588eeaa92ec7a9(r42021) original commit message: Don't fallback to the %StrictEqual / %Equal runtime functions for the generic CompareIC slow path, but use the (new) StrictEqual and Equal builtins instead. This avoids a performance cliff when mixing input types for strict equality sites. BUG= Review-Url: https://codereview.chromium.org/2612693002 Cr-Commit-Position: refs/heads/master@{#42080} Committed: https://chromium.googlesource.com/v8/v8/+/07a6449fb74cf1689e7959caf8d76281936e3ddf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
zhengxing.li
PTAL, thanks!
3 years, 11 months ago (2017-01-04 01:59:23 UTC) #2
chunyang.dai
On 2017/01/04 01:59:23, zhengxing.li wrote: > PTAL, thanks! LGTM. thanks
3 years, 11 months ago (2017-01-05 06:31:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612693002/1
3 years, 11 months ago (2017-01-05 06:32:47 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 06:54:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/07a6449fb74cf1689e7959caf8d76281936...

Powered by Google App Engine
This is Rietveld 408576698