Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2612683002: PlzNavigate: Pass the encoded resource transfer size to the renderer. (Closed)

Created:
3 years, 11 months ago by ananta
Modified:
3 years, 11 months ago
Reviewers:
jam
CC:
chromium-reviews, blink-reviews, jam, darin-cc_chromium.org, zork+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: Pass the encoded resource transfer size to the renderer. This should fix the http/tests/misc/resource-timing-sizes-tags.html layout test. The other test http/tests/inspector/resource-har-conversion.html needs an expectation change to allow the custom header which is passed for PlzNavigate. Will do that in a later patchset. Changes on this patch are to implement the GetTotalReceivedBytes() override for the StreamURLRequestJob class BUG=673745 Committed: https://crrev.com/0a9167f903f8aae02ca586fb920348a71d573544 Cr-Commit-Position: refs/heads/master@{#441409}

Patch Set 1 #

Patch Set 2 : PlzNavigate: Pass the encoded resource transfer size to the renderer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M content/browser/streams/stream_url_request_job.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/streams/stream_url_request_job.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
ananta
3 years, 11 months ago (2017-01-04 01:39:04 UTC) #2
jam
lgtm
3 years, 11 months ago (2017-01-04 17:28:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612683002/20001
3 years, 11 months ago (2017-01-04 18:07:05 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-04 18:11:49 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 18:21:50 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0a9167f903f8aae02ca586fb920348a71d573544
Cr-Commit-Position: refs/heads/master@{#441409}

Powered by Google App Engine
This is Rietveld 408576698