Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2612653002: Prefix Did{Start|Stop}Loading methods. (Closed)

Created:
3 years, 11 months ago by nasko
Modified:
3 years, 11 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prefix Did{Start|Stop}Loading methods. This CL prefixes the DidStartLoading and DidStopLoading methods in RenderFrameImpl, so they don't conflict with the WebFrameClient versions which currently start with lowercase letter. As part of the Blink rewrite to match Chromium style, those will be conflicting. BUG=582312 Committed: https://crrev.com/2d67b3c0fcb6e5ed693d90d8403e324033b7f804 Cr-Commit-Position: refs/heads/master@{#441372}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M components/pdf/renderer/pepper_pdf_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/renderer/render_frame.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
nasko
Hey Raymes and Daniel, Can you review this CL for me? It adds a prefix ...
3 years, 11 months ago (2017-01-04 00:31:03 UTC) #2
nasko
s/raymes/jochen/ jochen@, can you do an OWNERS review for components/pdf?
3 years, 11 months ago (2017-01-04 01:23:53 UTC) #6
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-04 06:56:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612653002/1
3 years, 11 months ago (2017-01-04 14:45:18 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 14:48:51 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 14:51:45 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d67b3c0fcb6e5ed693d90d8403e324033b7f804
Cr-Commit-Position: refs/heads/master@{#441372}

Powered by Google App Engine
This is Rietveld 408576698