Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 2612523002: Move bindings timers to frame-specific task runners. (Closed)

Created:
3 years, 11 months ago by dcheng
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move bindings timers to frame-specific task runners. BUG=624694 Committed: https://crrev.com/5e37ec3479d34b7429249d11f8d307f4ae9e4696 Cr-Commit-Position: refs/heads/master@{#441104}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
dcheng
My understanding from reading https://github.com/domenic/promises-unwrapping/blob/master/README.md and https://www.w3.org/Bugs/Public/show_bug.cgi?id=22296#c40 is that promises should be fulfilled on the ...
3 years, 11 months ago (2017-01-03 09:01:13 UTC) #4
dcheng
Note: there's one remaining non-frame specific timer in bindings in V8GCForContextDispose: for now, I believe ...
3 years, 11 months ago (2017-01-03 09:02:33 UTC) #5
haraken
LGTM
3 years, 11 months ago (2017-01-03 09:04:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612523002/1
3 years, 11 months ago (2017-01-03 09:15:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-03 10:25:31 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 10:29:22 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e37ec3479d34b7429249d11f8d307f4ae9e4696
Cr-Commit-Position: refs/heads/master@{#441104}

Powered by Google App Engine
This is Rietveld 408576698