Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2612513003: [turbofan] Inline calls to Date.now builtin. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Inline calls to Date.now builtin. Call the %DateCurrentTime runtime function directly instead, which is cheaper than calling the C++ builtin. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2612513003 Cr-Commit-Position: refs/heads/master@{#42028} Committed: https://chromium.googlesource.com/v8/v8/+/f1473c9bb360380ee090acd5257031b25cc740ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/compiler/js-builtin-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-03 12:43:59 UTC) #1
Jarin
lgtm
3 years, 11 months ago (2017-01-03 13:09:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612513003/1
3 years, 11 months ago (2017-01-03 13:10:52 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 13:12:33 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f1473c9bb360380ee090acd5257031b25cc...

Powered by Google App Engine
This is Rietveld 408576698