Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2612503002: X87: [turbofan] Improve codegen for 8- and 16-bit memory comparisons on Intel platforms. (Closed)

Created:
3 years, 11 months ago by zhengxing.li
Modified:
3 years, 11 months ago
Reviewers:
chunyang.dai, danno
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Improve codegen for 8- and 16-bit memory comparisons on Intel platforms. port be11812c53ff6c8ce320887bc76a3b60d8103695 (r41971) original commit message: Recognize and emit in-memory comparisons of 8-bit and 16-bit values with immediate values that fit. BUG= Review-Url: https://codereview.chromium.org/2612503002 Cr-Commit-Position: refs/heads/master@{#42017} Committed: https://chromium.googlesource.com/v8/v8/+/5892cc9b61ca596145fe9c9e83dfbb47980dd210

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -13 lines) Patch
M src/compiler/x87/instruction-selector-x87.cc View 2 chunks +44 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
zhengxing.li
PTAL, thanks!
3 years, 11 months ago (2017-01-03 03:50:43 UTC) #2
chunyang.dai
On 2017/01/03 03:50:43, zhengxing.li wrote: > PTAL, thanks! LGTM thanks
3 years, 11 months ago (2017-01-03 05:06:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612503002/1
3 years, 11 months ago (2017-01-03 05:29:01 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 05:55:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/5892cc9b61ca596145fe9c9e83dfbb47980...

Powered by Google App Engine
This is Rietveld 408576698