Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2612493002: Prevent app banners from displaying after desktop add to shelf. (Closed)

Created:
3 years, 11 months ago by dominickn
Modified:
3 years, 11 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent app banners from displaying after desktop add to shelf. This CL records an app banner "added to homescreen" event when a user manually adds a bookmark app to their desktop or shelf (via the overflow menu). This ensures that if the added site is a progressive web app, it will not be permitted to show an app banner if the user has manually installed it. This behaviour mirrors that on Android, which already records the "added to homescreen" event on launch and when the user manually adds a site to their homescreen. BUG=674227 Committed: https://crrev.com/e75fa3a99a360d6469ac93a442b3f06bddf57253 Cr-Commit-Position: refs/heads/master@{#441085}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -10 lines) Patch
M chrome/browser/extensions/bookmark_app_helper.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/extensions/bookmark_app_helper_unittest.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 3 chunks +21 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
dominickn
PTAL, thanks!
3 years, 11 months ago (2017-01-03 01:45:41 UTC) #4
benwells
lgtm
3 years, 11 months ago (2017-01-03 02:48:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612493002/1
3 years, 11 months ago (2017-01-03 02:51:02 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-03 02:55:37 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 02:57:44 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e75fa3a99a360d6469ac93a442b3f06bddf57253
Cr-Commit-Position: refs/heads/master@{#441085}

Powered by Google App Engine
This is Rietveld 408576698