Views: Remove DCHECK failing for ScrollViews, which can't be focused.

Views: Remove DCHECK failing for ScrollViews, which can't be focused.

Focus rings can be installed on ScrollViews, but FocusRing::Install() DCHECKs
whether the view with a focus ring attached has focus before this happens. This
doesn't make sense since ScrollViews can't be focused - the focus ring is
installed when whatever is contained inside the ScrollView has focus to prevent
the ring from being scrolled.

In particular this affects the collected cookies dialog, which hits the DCHECK
whenever the TreeView inside the ScrollView receives focus. This change deletes
this DCHECK.

BUG=676244
Committed: https://crrev.com/3c2faf580ef236142f2c1ed8a6491c3193becbfd
Cr-Commit-Position: refs/heads/master@{#441092}

[Patti Lor, 2017-01-02 23:49:09]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-02 23:49:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 00:47:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 00:47:14]

Dry run: This issue passed the CQ dry run.

[Patti Lor, 2017-01-03 04:14:54]

patricialor@chromium.org changed reviewers:
+ karandeepb@chromium.org, tapted@chromium.org

[Patti Lor, 2017-01-03 04:14:55]

Split off as requested (by Karan) from
https://codereview.chromium.org/2604303002/ :) +Trent as a reviewer because of
context into the bug + owner powers. PTAL! Thanks.

[tapted, 2017-01-03 04:21:12]

lgtm

[Patti Lor, 2017-01-03 05:30:36]

The CQ bit was checked by patricialor@chromium.org

[commit-bot: I haz the power, 2017-01-03 05:30:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 05:36:04]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483421436233190, "parent_rev":
"e6a7daf7031899e547469d1026baea9881021803", "commit_rev":
"c7fdf0067595b7fdeefa4192c5bb2eb787fa0c85"}

[commit-bot: I haz the power, 2017-01-03 05:36:55]

Description was changed from

==========
Views: Remove DCHECK failing for ScrollViews, which can't be focused.

Focus rings can be installed on ScrollViews, but FocusRing::Install() DCHECKs
whether the view with a focus ring attached has focus before this happens. This
doesn't make sense since ScrollViews can't be focused - the focus ring is
installed when whatever is contained inside the ScrollView has focus to prevent
the ring from being scrolled.

In particular this affects the collected cookies dialog, which hits the DCHECK
whenever the TreeView inside the ScrollView receives focus. This change deletes
this DCHECK.

BUG=676244
==========

to

==========
Views: Remove DCHECK failing for ScrollViews, which can't be focused.

Focus rings can be installed on ScrollViews, but FocusRing::Install() DCHECKs
whether the view with a focus ring attached has focus before this happens. This
doesn't make sense since ScrollViews can't be focused - the focus ring is
installed when whatever is contained inside the ScrollView has focus to prevent
the ring from being scrolled.

In particular this affects the collected cookies dialog, which hits the DCHECK
whenever the TreeView inside the ScrollView receives focus. This change deletes
this DCHECK.

BUG=676244

Review-Url: https://codereview.chromium.org/2612463002
==========

[commit-bot: I haz the power, 2017-01-03 05:36:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2017-01-03 05:39:30]

Description was changed from

==========
Views: Remove DCHECK failing for ScrollViews, which can't be focused.

Focus rings can be installed on ScrollViews, but FocusRing::Install() DCHECKs
whether the view with a focus ring attached has focus before this happens. This
doesn't make sense since ScrollViews can't be focused - the focus ring is
installed when whatever is contained inside the ScrollView has focus to prevent
the ring from being scrolled.

In particular this affects the collected cookies dialog, which hits the DCHECK
whenever the TreeView inside the ScrollView receives focus. This change deletes
this DCHECK.

BUG=676244

Review-Url: https://codereview.chromium.org/2612463002
==========

to

==========
Views: Remove DCHECK failing for ScrollViews, which can't be focused.

Focus rings can be installed on ScrollViews, but FocusRing::Install() DCHECKs
whether the view with a focus ring attached has focus before this happens. This
doesn't make sense since ScrollViews can't be focused - the focus ring is
installed when whatever is contained inside the ScrollView has focus to prevent
the ring from being scrolled.

In particular this affects the collected cookies dialog, which hits the DCHECK
whenever the TreeView inside the ScrollView receives focus. This change deletes
this DCHECK.

BUG=676244

Committed: https://crrev.com/3c2faf580ef236142f2c1ed8a6491c3193becbfd
Cr-Commit-Position: refs/heads/master@{#441092}
==========

[commit-bot: I haz the power, 2017-01-03 05:39:31]

Patchset 1 (id:??) landed as
https://crrev.com/3c2faf580ef236142f2c1ed8a6491c3193becbfd
Cr-Commit-Position: refs/heads/master@{#441092}