Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2612443002: Convert CheckedNumeric unary operators to constexpr (Closed)

Created:
3 years, 11 months ago by jschuh
Modified:
3 years, 11 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert remaining CheckedNumeric unary operators to constexpr This swaps out some unnecessarily complex checked functions with simpler wrappers that support constexpr. BUG=612995 Committed: https://crrev.com/7308c7f7745c8bce834250d1a93e3c4501c65ca4 Cr-Commit-Position: refs/heads/master@{#441239}

Patch Set 1 #

Patch Set 2 : docs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -71 lines) Patch
M base/numerics/safe_math.h View 1 chunk +16 lines, -17 lines 0 comments Download
M base/numerics/safe_math_impl.h View 1 2 chunks +29 lines, -54 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
jschuh
ptal - Should be a pretty trivial one to review.
3 years, 11 months ago (2017-01-02 20:53:06 UTC) #7
Tom Sepez
lgtm
3 years, 11 months ago (2017-01-03 18:46:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612443002/20001
3 years, 11 months ago (2017-01-03 18:51:16 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-03 23:10:09 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 23:13:21 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7308c7f7745c8bce834250d1a93e3c4501c65ca4
Cr-Commit-Position: refs/heads/master@{#441239}

Powered by Google App Engine
This is Rietveld 408576698