Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2612433002: Remove CRWWebControllerProvider (Closed)

Created:
3 years, 11 months ago by gambard
Modified:
3 years, 11 months ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, pkl (ping after 24h if needed), browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, noyau+watch_chromium.org, stkhapugin, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove CRWWebControllerProvider WebControllerProvider is not used anymore, it can be removed. BUG=546231 Committed: https://crrev.com/0ef27f64524240f94e16e7d7d9d6e7958e65b868 Cr-Commit-Position: refs/heads/master@{#441393}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -381 lines) Patch
M components/autofill/ios/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/app/startup/provider_registration.mm View 2 chunks +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/reading_list/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/web/BUILD.gn View 1 chunk +0 lines, -20 lines 0 comments Download
M ios/chrome/browser/web/DEPS View 1 1 chunk +0 lines, -5 lines 0 comments Download
D ios/chrome/browser/web/web_controller_provider_factory_impl.h View 1 chunk +0 lines, -24 lines 0 comments Download
D ios/chrome/browser/web/web_controller_provider_factory_impl.mm View 1 chunk +0 lines, -22 lines 0 comments Download
D ios/chrome/browser/web/web_controller_provider_impl.h View 1 chunk +0 lines, -36 lines 0 comments Download
D ios/chrome/browser/web/web_controller_provider_impl.mm View 1 chunk +0 lines, -72 lines 0 comments Download
D ios/public/provider/web/BUILD.gn View 1 chunk +0 lines, -21 lines 0 comments Download
D ios/public/provider/web/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D ios/public/provider/web/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D ios/public/provider/web/web_controller_provider.h View 1 chunk +0 lines, -63 lines 0 comments Download
D ios/public/provider/web/web_controller_provider.mm View 1 chunk +0 lines, -33 lines 0 comments Download
D ios/public/provider/web/web_controller_provider_factory.h View 1 chunk +0 lines, -38 lines 0 comments Download
D ios/public/provider/web/web_controller_provider_factory.mm View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
gambard
PTAL.
3 years, 11 months ago (2017-01-02 15:50:06 UTC) #2
rohitrao (ping after 24h)
Eugene or kkhoromoto, can you be the lead reviewer on this? Thanks!
3 years, 11 months ago (2017-01-03 14:16:10 UTC) #3
Justin Donnelly
components/autofill/ios/browser/BUILD.gn lgtm
3 years, 11 months ago (2017-01-03 15:16:20 UTC) #4
Eugene But (OOO till 7-30)
lgtm Thank you for doing this! https://codereview.chromium.org/2612433002/diff/1/ios/chrome/browser/web/web_controller_provider_impl.mm File ios/chrome/browser/web/web_controller_provider_impl.mm (left): https://codereview.chromium.org/2612433002/diff/1/ios/chrome/browser/web/web_controller_provider_impl.mm#oldcode10 ios/chrome/browser/web/web_controller_provider_impl.mm:10: #import "ios/web/web_state/ui/crw_web_controller.h" Could ...
3 years, 11 months ago (2017-01-03 17:41:16 UTC) #5
gambard
Thanks https://codereview.chromium.org/2612433002/diff/1/ios/chrome/browser/web/web_controller_provider_impl.mm File ios/chrome/browser/web/web_controller_provider_impl.mm (left): https://codereview.chromium.org/2612433002/diff/1/ios/chrome/browser/web/web_controller_provider_impl.mm#oldcode10 ios/chrome/browser/web/web_controller_provider_impl.mm:10: #import "ios/web/web_state/ui/crw_web_controller.h" On 2017/01/03 17:41:16, Eugene But wrote: ...
3 years, 11 months ago (2017-01-04 09:04:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2612433002/20001
3 years, 11 months ago (2017-01-04 15:32:12 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-04 16:43:29 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 16:45:21 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/0ef27f64524240f94e16e7d7d9d6e7958e65b868
Cr-Commit-Position: refs/heads/master@{#441393}

Powered by Google App Engine
This is Rietveld 408576698