Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: Source/bindings/scripts/utilities.py

Issue 261243002: Add support for [Global] / [PrimaryGlobal] IDL extended attributes (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove non-ASCII character in comment Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/utilities.py
diff --git a/Source/bindings/scripts/utilities.py b/Source/bindings/scripts/utilities.py
index 0f16281b79fb434dd877b586cb211b245dc9a9ad..747d64e9be5fffbb3523c086300ac322ecda39e9 100644
--- a/Source/bindings/scripts/utilities.py
+++ b/Source/bindings/scripts/utilities.py
@@ -93,13 +93,13 @@ def get_parent_interface(file_contents):
def get_interface_extended_attributes_from_idl(file_contents):
- match = re.search(r'\[(.*)\]\s*'
+ match = re.search(r'^\s*\[(.*)\]\s*'
Inactive 2014/05/04 21:40:39 Without this fix, the comments before the extended
Nils Barth (inactive) 2014/05/07 01:55:57 Hmm...could you instead try putting the # Strip co
Inactive 2014/05/07 15:45:12 Done.
r'((callback|partial)\s+)?'
r'(interface|exception)\s+'
r'\w+\s*'
r'(:\s*\w+\s*)?'
r'{',
- file_contents, flags=re.DOTALL)
+ file_contents, flags=re.DOTALL | re.MULTILINE)
if not match:
return {}
# Strip comments

Powered by Google App Engine
This is Rietveld 408576698