Add support for [Global] / [PrimaryGlobal] IDL extended attributes

Source/bindings/scripts/utilities.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Utility functions (file reading, simple IDL parsing by regexes) for IDL build.
 
 Design doc: http://www.chromium.org/developers/design-documents/idl-build
 """
 
 import os
@@ skipping 75 matching lines @@
 def get_parent_interface(file_contents):
     match = re.search(r'interface\s+'
                       r'\w+\s*'
                       r':\s*(\w+)\s*'
                       r'{',
                       file_contents)
     return match and match.group(1)
 
 
 def get_interface_extended_attributes_from_idl(file_contents):
-    match = re.search(r'\[(.*)\]\s*'
+    match = re.search(r'^\s*\[(.*)\]\s*'

[Inactive, 2014/05/04 21:40:39]

Without this fix, the comments before the extended attributes in Window.idl was
confusing the regex.

Parsed extended attributes before:
{'WillBeGarbageCollected': '', 'Custom': 'ToV8', 'ImplementedAs': 'DOMWindow',
'DoNotCheckSecurity]\n[\n    PrimaryGlobal': '', 'CheckSecurity': 'Frame'}

after:
{'WillBeGarbageCollected': '', 'Custom': 'ToV8', 'ImplementedAs': 'DOMWindow',
'PrimaryGlobal': '', 'CheckSecurity': 'Frame'}

The DoNotCheckSecurity is in a comments are shouldn't be in the parsed
attributes, also, the first real extended attribute (PrimaryGlobal) was ignored
because it was appended to the bad extended attribute.

[Nils Barth (inactive), 2014/05/07 01:55:57]

Hmm...could you instead try putting the # Strip comments
section *before* this main match?
That's more correct and less obscure.
(Properly should strip comments from whole file first, not just from match.)

[Inactive, 2014/05/07 15:45:12]

Done.

                       r'((callback|partial)\s+)?'
                       r'(interface|exception)\s+'
                       r'\w+\s*'
                       r'(:\s*\w+\s*)?'
                       r'{',
-                      file_contents, flags=re.DOTALL)
+                      file_contents, flags=re.DOTALL | re.MULTILINE)
     if not match:
         return {}
     # Strip comments
     # re.compile needed b/c Python 2.6 doesn't support flags in re.sub
     single_line_comment_re = re.compile(r'//.*$', flags=re.MULTILINE)
     block_comment_re = re.compile(r'/\*.*?\*/', flags=re.MULTILINE | re.DOTALL)
     extended_attributes_string = re.sub(single_line_comment_re, '', match.group(1))
     extended_attributes_string = re.sub(block_comment_re, '', extended_attributes_string)
     extended_attributes = {}
     # FIXME: this splitting is WRONG: it fails on ExtendedAttributeArgList like
@@ skipping 10 matching lines @@
 
 def get_put_forward_interfaces_from_idl(file_contents):
     put_forwards_pattern = (r'\[[^\]]*PutForwards=[^\]]*\]\s+'
                             r'readonly\s+'
                             r'attribute\s+'
                             r'(\w+)')
     return sorted(set(match.group(1)
                       for match in re.finditer(put_forwards_pattern,
                                                file_contents,
                                                flags=re.DOTALL)))